Bug 1638099 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
This patch introduces a new xpcshell test that covers the behavior expected by the changes
applied from D119532.

The current testing strategy is based on the same Firefox DevTools internal API that about:debugging
is using to detect when a worker is being spawned and terminated, and it does also use the same
strategy used by about:addons to force spawn a registered service worker (by calling the
nsIServiceWorkerRegistrationInfo.attachDebugger method).

TODO:
- [ ] double-check with ochameau that the test is using the DevTools API correctly,
      without anything not actually necessary (and in a non invasive way, we don't want
      to rely on any part of the DevTools API that is not supposed to be called directly,
      or that may have to be removed or replaced soon)
- [ ] after a feedback round from a DevTools engineer, add an additional reviewer from the
      WebExtensions team (which also help to make sure the testing approach is properly
      shared with at least one other engineer in the team).

Depends on D119532
Revision 1 by
on 
This patch introduces a new xpcshell test that covers the behavior expected by the changes
applied from D119532.

The current testing strategy is based on the same Firefox DevTools internal API that about:debugging
is using to detect when a worker is being spawned and terminated, and it does also use the same
strategy used by about:addons to force spawn a registered service worker (by calling the
nsIServiceWorkerRegistrationInfo.attachDebugger method).

TODO:
- [x] double-check with ochameau that the test is using the DevTools API correctly,
      without anything not actually necessary (and in a non invasive way, we don't want
      to rely on any part of the DevTools API that is not supposed to be called directly,
      or that may have to be removed or replaced soon)
- [x] after a feedback round from a DevTools engineer, add an additional reviewer from the
      WebExtensions team (which also help to make sure the testing approach is properly
      shared with at least one other engineer in the team).

Depends on D119532

Back to Bug 1638099 Comment 3