Bug 1638332 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Harry Twyford [:harry] from comment #1)
> This works fine when typing in a RTL language in a RTL UI. The only issue is typing in a LTR language in a RTL UI (as in the screenshot).

Note that the same is reproducible with RTL text in LTR UI (see the dupe for screenshots and STR).

> We spoke to UX and we should just switch the ellipses to the other side in that case.

I'd suggest to just drop the tail suggestion logic altogether when this happens, because you'll lose the direction of reading the text. Personally I find it very confusing.
Another option could be to change [this rule](https://searchfox.org/mozilla-central/rev/26b13464c2beb26e0d864d561c30e817a85c348a/browser/themes/shared/urlbarView.inc.css#379) so it won't match if a) the UI is LTR and b) the text is RTL (and vice versa), and move the ellipses to the other side. Though this will of course lose the nice alignment of the end of the typed text to the suggestions, and make the UX different based on entered text...
(In reply to Harry Twyford [:harry] from comment #1)
> This works fine when typing in a RTL language in a RTL UI. The only issue is typing in a LTR language in a RTL UI (as in the screenshot).

Note that the same is reproducible with RTL text in LTR UI (see the dupe for screenshots and STR).

> We spoke to UX and we should just switch the ellipses to the other side in that case.

I'd suggest to just drop the tail suggestion logic altogether when this happens, because you'll lose the direction of reading the text. Personally I find it very confusing.
Another option could be to change [this rule](https://searchfox.org/mozilla-central/rev/26b13464c2beb26e0d864d561c30e817a85c348a/browser/themes/shared/urlbarView.inc.css#379) so it won't match if a) the UI is LTR and b) the text is RTL (and vice versa), and move the ellipses to the other side. Though this, of course, will lose the nice alignment of the end of the typed text to the suggestions, and make the UX different based on entered text...

Back to Bug 1638332 Comment 5