Bug 1638596 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Review of attachment 9149650 [details] [diff] [review]:
-----------------------------------------------------------------

This looks quite good overall to me!  Will be a nice improvement, less XPCOM and ability to use OS.File, etc.  Apologies for the delay on the feedback.  The patch no longer applies cleanly due to changes to import-export.js for the new import dialog (bug 1631902).
Review of attachment 9149650 [details] [diff] [review]:
-----------------------------------------------------------------

This looks quite good overall to me!  Will be a nice improvement, less XPCOM and ability to use OS.File, TextEncoder, etc.  Apologies for the delay on the feedback.  The patch no longer applies cleanly due to changes to import-export.js for the new import dialog (bug 1631902).

Back to Bug 1638596 Comment 1