Bug 1640197 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Mats Palmgren (:mats) from comment #11)
> Created attachment 9172958 [details] [diff] [review]
> propagate OverflowIncomplete status if we have overflow or previous pages have it
> 
> So here's a rough sketch of what I meant with propagating an incomplete status up to PageSequenceFrame to let it know that it should create another page.  It creates the necessary pages to render Testcase #2, but it generates one (unnecessary) blank page at the end since I just copied the GetPreviousPageContentFrames loop you wrote (which tests if previous pages overflows onto this page, whereas in this case we should test if that overflow overflows THIS page too).
> 
> Also, I wonder if all this can be simplified by storing the overflow on the frames themselves (nsPageContentFrame or nsPageFrame) and accumulating it so that say if page 1 overflows 1000px and a page size is 700px then page 1 would store 1000px, and page 2 would store `max(300px, <it's own overflow>)` etc.  Then we don't need `GetPreviousPageContentFrames` (which is O(n^2)) at all since we only need to peek at the previous continuation to get the accumulated remaining overflow.  Note that these frame classes are only used for printing so we don't need to worry about memory size - we can add more fields if that helps.

I didn't get very far with this. It seems that `nsPageContentFrame::Reflow` does not work as expected for the first page, and the overflow is never set when this function is called. This might be related to bug 1655856.
edit: This was confusion about layout debugger.

Back to Bug 1640197 Comment 12