Bug 1642313 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I hadn't seen this before but when working on bug 1642044, I started hitting 

```
./mach reftest --this-chunk 1 --total-chunks 100
...
TypeError: '<' not supported between instances of 'dict' and 'dict'

  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 208, in run_reftest
    return self._run_reftest(**kwargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 242, in _run_reftest
    return reftest.run_desktop_test(**kwargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 87, in run_desktop_test
    rv = runreftest.run_test_harness(parser, args)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 1035, in run_test_harness
    result = reftest.runTests(options.tests, options)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 626, in runTests
    return self.runSerialTests(manifests, options, cmdargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 968, in runSerialTests
    tests = self.getActiveTests(manifests, options)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 925, in getActiveTests
    tests = mp.active_tests(exists=False, filters=filters)
  File "/home/bclary/mozilla/builds/autoland/mozilla/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 804, in active_tests
    tests = fn(tests, values)
  File "/home/bclary/mozilla/builds/autoland/mozilla/testing/mozbase/manifestparser/manifestparser/filters.py", line 298, in __call__
    tests_by_manifest.sort(reverse=True, key=lambda x: (len(x), x))
```

ahal, Do you have any suggestion on how to appropriately sort tests_by_manifest?
Revision 1 by
on 
I hadn't seen this before but when working on bug 1642044, I started hitting 

```
python3 ./mach reftest --this-chunk 1 --total-chunks 100
...
TypeError: '<' not supported between instances of 'dict' and 'dict'

  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 208, in run_reftest
    return self._run_reftest(**kwargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 242, in _run_reftest
    return reftest.run_desktop_test(**kwargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/mach_commands.py", line 87, in run_desktop_test
    rv = runreftest.run_test_harness(parser, args)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 1035, in run_test_harness
    result = reftest.runTests(options.tests, options)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 626, in runTests
    return self.runSerialTests(manifests, options, cmdargs)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 968, in runSerialTests
    tests = self.getActiveTests(manifests, options)
  File "/home/bclary/mozilla/builds/autoland/mozilla/layout/tools/reftest/runreftest.py", line 925, in getActiveTests
    tests = mp.active_tests(exists=False, filters=filters)
  File "/home/bclary/mozilla/builds/autoland/mozilla/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 804, in active_tests
    tests = fn(tests, values)
  File "/home/bclary/mozilla/builds/autoland/mozilla/testing/mozbase/manifestparser/manifestparser/filters.py", line 298, in __call__
    tests_by_manifest.sort(reverse=True, key=lambda x: (len(x), x))
```

ahal, Do you have any suggestion on how to appropriately sort tests_by_manifest?

Back to Bug 1642313 Comment 0