Bug 1642676 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Cosmin Sabou [:CosminS] from comment #8)
> Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=307274326&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307273503&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307274224&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307274235&repo=autoland

These failures look all related to tests running in fisson-enabled jobs, which honestly I should have actually expected to happen ([1]) and checked upfront.

I'm evaluating some options to deal with these failures and I'm going to discuss them with :asuth to agreed on a preferred approach.

I'm going to re-aiming to have this ready to be pushed on autoland on early 80 cycle.

[1]: because as part of the change there is an explicit check in RemoteWorkerChild that is verify that the remote worker remoteType does match the content process remoteType and explictly fail it doesn't, and that is what is triggering this failure. In my opinion we should keep that check in place but also deal with Fission-enabled jobs more explicitly than I originally agreed with :asuth
(In reply to Cosmin Sabou [:CosminS] from comment #8)
> Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=307274326&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307273503&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307274224&repo=autoland
> https://treeherder.mozilla.org/logviewer.html#?job_id=307274235&repo=autoland

These failures look all related to tests running in Fission-enabled jobs, which honestly I should have actually expected to happen ([1]) and checked upfront.

I'm evaluating some options to deal with these failures and I'm going to discuss them with :asuth to agreed on a preferred approach.

I'm going to re-aiming to have this ready to be pushed on autoland on early 80 cycle.

[1]: because as part of the change there is an explicit check in RemoteWorkerChild that is verify that the remote worker remoteType does match the content process remoteType and explicitly fail it doesn't, and that is what is triggering this failure. In my opinion we should keep that check in place but also deal with Fission-enabled jobs more explicitly than I originally agreed with :asuth

Back to Bug 1642676 Comment 9