Bug 1649301 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.


(In reply to Punam Dahiya [:pdahiya] from comment #9)
> Hi Eric
> 
> Couple of things that came out of review feedback
> 
> a) Can we get video in both mp4/webm and apng format to compare file sizes. My understanding video is going to be same in light and dark theme, is that correct? If transparency is required than we need apng format.
>  I've attached apngs to try out. Let me know how they work out. If we need to use the mp4 files we'll need to create a dark theme version as well. I've also tried to compress the mp4s a little more and also exported webm (which seem to be even smaller) - I will attach to the bug
> Either way file size should be prioritized, if mp4/webm compresses better than apng, then it might be worth dropping transparency requirement. There is a chance using animation is going to cause installer size regressions  (like it happened with the pinned tabs ~0.5%+) .
> 
> b) need to support RTL: this means a separate asset (A mirrored asset wouldn't be a correct representation as the ETP icon looks the same as in LTR)
> When we spoke yesterday it sounds like we don't need to worry about this for the test. When needed I can create these assets :)
> Thanks!

(In reply to Punam Dahiya [:pdahiya] from comment #9)
> Hi Eric
> 
> Couple of things that came out of review feedback
> 
> a) Can we get video in both mp4/webm and apng format to compare file sizes. My understanding video is going to be same in light and dark theme, is that correct? If transparency is required than we need apng format.
I've attached apngs to try out. Let me know how they work out. If we need to use the mp4 files we'll need to create a dark theme version as well. I've also tried to compress the mp4s a little more and also exported webm (which seem to be even smaller) - I will attach to the bug
> Either way file size should be prioritized, if mp4/webm compresses better than apng, then it might be worth dropping transparency requirement. There is a chance using animation is going to cause installer size regressions  (like it happened with the pinned tabs ~0.5%+) .
> 
> b) need to support RTL: this means a separate asset (A mirrored asset wouldn't be a correct representation as the ETP icon looks the same as in LTR)
When we spoke yesterday it sounds like we don't need to worry about this for the test. When needed I can create these assets :)
> Thanks!

(In reply to Punam Dahiya [:pdahiya] from comment #9)
> Hi Eric
> 
> Couple of things that came out of review feedback
> 
> a) Can we get video in both mp4/webm and apng format to compare file sizes. My understanding video is going to be same in light and dark theme, is that correct? If transparency is required than we need apng format.

I've attached apngs to try out. Let me know how they work out. If we need to use the mp4 files we'll need to create a dark theme version as well. I've also tried to compress the mp4s a little more and also exported webm (which seem to be even smaller) - I will attach to the bug

> Either way file size should be prioritized, if mp4/webm compresses better than apng, then it might be worth dropping transparency requirement. There is a chance using animation is going to cause installer size regressions  (like it happened with the pinned tabs ~0.5%+) .
> 
> b) need to support RTL: this means a separate asset (A mirrored asset wouldn't be a correct representation as the ETP icon looks the same as in LTR)

When we spoke yesterday it sounds like we don't need to worry about this for the test. When needed I can create these assets :)

> Thanks!

Back to Bug 1649301 Comment 11