Bug 1649771 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The DAMP documentation contains instructions to run DAMP tests and create a profile.
https://docs.firefox-dev.tools/tests/performance-tests.html

According to the alert, the most impacted test is `complicated.inspector.reload.DAMP` (>40%). With some luck, this should be significant enough to be visible locally.

```
./mach talos-test --activeTests damp --subtests complicated.inspector --cycles 1 --tppagecycles 1 --geckoProfile --geckoProfileEntries 100000000
```

Try to create one profile without your patch and one with the patch, and see if you can spot any difference.
No
Revision 1 by
on 
The DAMP documentation contains instructions to run DAMP tests and create a profile.
https://docs.firefox-dev.tools/tests/performance-tests.html

According to the alert, the most impacted test is `complicated.inspector.reload.DAMP` (>40%). With some luck, this should be significant enough to be visible locally.

```
./mach talos-test --activeTests damp --subtests complicated.inspector --cycles 1 --tppagecycles 1 --geckoProfile --geckoProfileEntries 100000000
```

Try to create one profile without your patch and one with the patch, and see if you can spot any difference.
Now, considering that the regression comes from a netmonitor actor change, we might need to modify the test slightly to first load the netmonitor actor?
Revision 2 by
on 
The DAMP documentation contains instructions to run DAMP tests and create a profile.
https://docs.firefox-dev.tools/tests/performance-tests.html

According to the alert, the most impacted test is `complicated.inspector.reload.DAMP` (>40%). With some luck, this should be significant enough to be visible locally.

```
./mach talos-test --activeTests damp --subtests complicated.inspector --cycles 1 --tppagecycles 1 --gecko-profile --gecko-profile-entries 100000000
```

Try to create one profile without your patch and one with the patch, and see if you can spot any difference.
Now, considering that the regression comes from a netmonitor actor change, we might need to modify the test slightly to first load the netmonitor actor?

Back to Bug 1649771 Comment 6