Bug 1650583 Comment 20 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Thanks again. So surface creation fails with `0x3000`. The spec (1) says:
> EGL_BAD_MATCH: Arguments are inconsistent (for example, a valid context requires buffers not supplied by a valid surface). 

We currently use the custom GLX based function`FindVisual` (2) to set to the appropriate visual for the window. The following build uses a fallback path with `gdk_screen_get_rgba_visual` instead - this *might* avoid the issue and gets rid of more GLX specific code - on mesa it appears to work just as well, I'm just not sure about non-composited window managers. OTOH I'm also not sure if I should care :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25afa11020dc39c8651598b48b10e92c5496e7b1

If anyone could try and, whether it works or not, post the output - again that would be much appreciated.

1: https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglGetError.xhtml
2: https://searchfox.org/mozilla-central/source/gfx/gl/GLContextProviderGLX.cpp#791
Thanks again. So surface creation fails with `0x3009`. The spec (1) says:
> EGL_BAD_MATCH: Arguments are inconsistent (for example, a valid context requires buffers not supplied by a valid surface). 

We currently use the custom GLX based function`FindVisual` (2) to set to the appropriate visual for the window. The following build uses a fallback path with `gdk_screen_get_rgba_visual` instead - this *might* avoid the issue and gets rid of more GLX specific code - on mesa it appears to work just as well, I'm just not sure about non-composited window managers. OTOH I'm also not sure if I should care :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25afa11020dc39c8651598b48b10e92c5496e7b1

If anyone could try and, whether it works or not, post the output - again that would be much appreciated.

1: https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglGetError.xhtml
2: https://searchfox.org/mozilla-central/source/gfx/gl/GLContextProviderGLX.cpp#791

Back to Bug 1650583 Comment 20