Bug 1652894 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I see.

Video has the added complication that it can consist of multiple planes, for example NV12 video has a Y plane and a CbCr plane. So we'd also need to decide whether SWGL wants to have a texture per plane (like hardware GL) or whether we want to do the conversion to RGB outside of SWGL, like BasicCompositor.
And I'm not sure if there is a good "generic" place for readback.

For reference, here's where we get the data out of an IOSurface for BasicCompositor: https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/gfx/layers/basic/MacIOSurfaceTextureHostBasic.cpp#44-50
We expose the contents as a SourceSurface that contains RGB data.
I see.

Video has the added complication that it can consist of multiple planes, for example NV12 video has a Y plane and a CbCr plane. So we'd also need to decide whether SWGL wants to have a texture per plane (like hardware GL) or whether we want to do the conversion to RGB outside of SWGL, like BasicCompositor.
And I'm not sure if there is a good "general" place for readback.

For reference, here's where we get the data out of an IOSurface for BasicCompositor: https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/gfx/layers/basic/MacIOSurfaceTextureHostBasic.cpp#44-50
We expose the contents as a SourceSurface that contains RGB data.
I see.

Video has the added complication that it can consist of multiple planes, for example NV12 video has a Y plane and a CbCr plane. So we'd also need to decide whether SWGL wants to have a texture per plane (like hardware GL) or whether we want to do the conversion to RGB outside of SWGL, like BasicCompositor.
And I'm not sure where a "general" place for readback would be.

For reference, here's where we get the data out of an IOSurface for BasicCompositor: https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/gfx/layers/basic/MacIOSurfaceTextureHostBasic.cpp#44-50
We expose the contents as a SourceSurface that contains RGB data.

Back to Bug 1652894 Comment 4