Bug 1654658 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Searched a bit for XGetWindowAttributes:
Latest GPU process XGetWindowAttributes crash seems to be bp-449eccc2-2b1d-48eb-92bc-539310210824 with version **82**.0b9.
* Flash has been removed afterwards in 89 by bug 1682030.
* There was a Flash player problem with XGetWindowAttributes: bug 921848, https://bugs.webkit.org/show_bug.cgi?id=163159
* XGetWindowAttributes "deadlock", "known thread-safety issues": https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/26

-----

(Chris Peterson [:cpeterson] from comment #3)
> Crash report: https://crash-stats.mozilla.org/report/index/1ee95652-a060-445c-bbff-89a950210713

That one has:
> GraphicsCriticalError 	|[G0][GFX1-]: Failed to create EGLSurface!: 0x3009 (t=1.05895) |[G1][GFX1-]: Failed to create EGLSurface (t=1.05898) 

GLX is still the default.
If I (non-programmer) understand correctly, MOZ_X11_EGL=1/proprietary Nvidia must have perfectly matching visual between X11 and EGL, otherwise it crashes. Mesa does not seem this strict.
Example of such a crash on X11 Mate desktop environment: bug 1677314
Nvidia driver 470 has many improvements for EGL/Dmabuf/Xwayland/Wayland.
EGL/X11 Mate desktop/proprietary Nvidia seems(!) to work fine now: https://bug1729900.bmoattachments.org/attachment.cgi?id=9240298

This change was required for WebRender in the GPU process and OOP Webextensions: https://hg.mozilla.org/mozilla-central/rev/bb6817615317
It seems [windowAttrs](https://searchfox.org/mozilla-central/rev/aa46c2dcccbc6fd4265edca05d3d00cccdfc97b9/widget/gtk/GtkCompositorWidget.cpp#43-44) could be used with the struct's default values (=no visual?) if XGetWindowAttributes() fails.
Searched a bit for XGetWindowAttributes:
Latest GPU process XGetWindowAttributes crash seems to be bp-449eccc2-2b1d-48eb-92bc-539310210824 with version **82**.0b9.
* Flash has been removed afterwards in 89 by bug 1682030.
* There was a Flash player problem with XGetWindowAttributes: bug 921848, https://bugs.webkit.org/show_bug.cgi?id=163159
* XGetWindowAttributes "deadlock", "known thread-safety issues": https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/26

-----

(Chris Peterson [:cpeterson] from comment #3)
> Crash report: https://crash-stats.mozilla.org/report/index/1ee95652-a060-445c-bbff-89a950210713

> [@ libglib-2.0.so.0@0x5f0f8 ]

That one has:
> GraphicsCriticalError 	|[G0][GFX1-]: Failed to create EGLSurface!: 0x3009 (t=1.05895) |[G1][GFX1-]: Failed to create EGLSurface (t=1.05898) 

GLX is still the default.
If I (non-programmer) understand correctly, MOZ_X11_EGL=1/proprietary Nvidia must have perfectly matching visual between X11 and EGL, otherwise it crashes. Mesa does not seem this strict.
Example of such a crash on X11 Mate desktop environment: bug 1677314
Nvidia driver 470 has many improvements for EGL/Dmabuf/Xwayland/Wayland.
EGL/X11 Mate desktop/proprietary Nvidia seems(!) to work fine now: https://bug1729900.bmoattachments.org/attachment.cgi?id=9240298

This change was required for WebRender in the GPU process and OOP Webextensions: https://hg.mozilla.org/mozilla-central/rev/bb6817615317
It seems [windowAttrs](https://searchfox.org/mozilla-central/rev/aa46c2dcccbc6fd4265edca05d3d00cccdfc97b9/widget/gtk/GtkCompositorWidget.cpp#43-44) could be used with the struct's default values (=no visual?) if XGetWindowAttributes() fails.
Searched a bit for XGetWindowAttributes:
Latest GPU process XGetWindowAttributes crash seems to be bp-449eccc2-2b1d-48eb-92bc-539310210824 with version **82**.0b9.
* Flash has been removed afterwards in 89 by bug 1682030.
* There was a Flash player problem with XGetWindowAttributes: bug 921848, https://bugs.webkit.org/show_bug.cgi?id=163159
* XGetWindowAttributes "deadlock", "known thread-safety issues": https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/26

-----

(Chris Peterson [:cpeterson] from comment #3)
> Crash report: https://crash-stats.mozilla.org/report/index/1ee95652-a060-445c-bbff-89a950210713

> [@ libglib-2.0.so.0@0x5f0f8 ]

That one has:
> GraphicsCriticalError 	|[G0][GFX1-]: Failed to create EGLSurface!: 0x3009 (t=1.05895) |[G1][GFX1-]: Failed to create EGLSurface (t=1.05898) 

GLX is still the default.
If I (non-programmer) understand correctly, MOZ_X11_EGL=1/proprietary Nvidia must have perfectly matching visual between X11 and EGL, otherwise it crashes. Mesa does not seem this strict.
Example of such a crash on X11 Mate desktop environment: bug 1677314
Nvidia driver 470 has many improvements for EGL/Dmabuf/Xwayland/Wayland.
EGL/X11 XFCE desktop/proprietary Nvidia seems(!) to work fine now: https://bug1729900.bmoattachments.org/attachment.cgi?id=9240298

This change was required for WebRender in the GPU process and OOP Webextensions: https://hg.mozilla.org/mozilla-central/rev/bb6817615317
It seems [windowAttrs](https://searchfox.org/mozilla-central/rev/aa46c2dcccbc6fd4265edca05d3d00cccdfc97b9/widget/gtk/GtkCompositorWidget.cpp#43-44) could be used with the struct's default values (=no visual?) if XGetWindowAttributes() fails.

Back to Bug 1654658 Comment 11