Bug 1655627 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Review of attachment 9172966 [details] [diff] [review]:
-----------------------------------------------------------------

Provisional r+ because this does look like it'd prevent the crashes we see at the moment.
But... if the aDisplayConsumer isn't a docshell, that null url will case a crash (well... an assert) down in [`RunMailboxUrl()`](https://searchfox.org/comm-central/search?q=nsMailboxService%3A%3ARunMailboxUrl) instead, where it calls 
[`nsMailboxProtocol::Initialize()`](https://searchfox.org/comm-central/search?q=nsMailboxProtocol%3A%3AInitialize).

Not sure how much of an issue this is in practice though.
Review of attachment 9172966 [details] [diff] [review]:
-----------------------------------------------------------------

Provisional r+ because this does look like it'd prevent the crashes we see at the moment.
But... if the aDisplayConsumer isn't a docshell, that null url will case a crash (well... an assert) down in RunMailboxUrl() (https://searchfox.org/comm-central/search?q=nsMailboxService%3A%3ARunMailboxUrl) instead, where it calls 
nsMailboxProtocol::Initialize() (https://searchfox.org/comm-central/search?q=nsMailboxProtocol%3A%3AInitialize).

Not sure how much of an issue this is in practice though.
Review of attachment 9172966 [details] [diff] [review]:
-----------------------------------------------------------------

Provisional r+ because this does look like it'd prevent the crashes we see at the moment.
But... if the aDisplayConsumer isn't a docshell, that null url will cause a crash (well... an assert) down in RunMailboxUrl() (https://searchfox.org/comm-central/search?q=nsMailboxService%3A%3ARunMailboxUrl) instead, where it calls 
nsMailboxProtocol::Initialize() (https://searchfox.org/comm-central/search?q=nsMailboxProtocol%3A%3AInitialize).

Not sure how much of an issue this is in practice though.

Back to Bug 1655627 Comment 4