Bug 1658605 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Harry Twyford [:harry] from comment #4)
> We can certainly revert to the old behaviour, but my understanding is that search mode is supposed to replace alias use altogether; aliases will just become a way to enter search mode. Maybe we could enter search mode when autofill is confirmed with `right`?

I think I didn't explain well, I'm typing "@ama", I get suggested "@ama[zon]" I press RIGHT to confirm the "zon" completion, at this point search mode should be enabled I should be able to continue typing, without having to further type another space.
(In reply to Harry Twyford [:harry] from comment #4)
> We can certainly revert to the old behaviour, but my understanding is that search mode is supposed to replace alias use altogether; aliases will just become a way to enter search mode. Maybe we could enter search mode when autofill is confirmed with `right`?

I think I didn't explain well, I'm typing "@ama", I get suggested "@ama[zon]" I press RIGHT to confirm the "zon" completion, at this point search mode should be enabled, I should be able to continue typing, without having to further type another space.
(In reply to Harry Twyford [:harry] from comment #4)
> We can certainly revert to the old behaviour, but my understanding is that search mode is supposed to replace alias use altogether; aliases will just become a way to enter search mode. Maybe we could enter search mode when autofill is confirmed with `right`?

I think I didn't explain well, I'm typing "@ama", I get suggested "@ama[zon]" I press RIGHT to confirm the "zon" completion, at this point search mode should be enabled, I should be able to continue typing, without having to further type another space.
If I press Enter instead of Right, it works as expected.
(In reply to Harry Twyford [:harry] from comment #4)
> We can certainly revert to the old behaviour, but my understanding is that search mode is supposed to replace alias use altogether; aliases will just become a way to enter search mode. Maybe we could enter search mode when autofill is confirmed with `right`?

I think I didn't explain well, I'm typing "@ama", I get suggested "@ama[zon]" I press RIGHT to confirm the "zon" completion, at this point search mode should be enabled, I should be able to continue typing, without having to further type another space.
Not entering search mode means that I get "@amazonmysearch" that is definitely not expected, I end up searching that string on Google.
If I press Enter instead of Right, it works as expected.
(In reply to Harry Twyford [:harry] from comment #4)
> We can certainly revert to the old behaviour, but my understanding is that search mode is supposed to replace alias use altogether; aliases will just become a way to enter search mode. Maybe we could enter search mode when autofill is confirmed with `right`?

I think I didn't explain well, I'm typing "@ama", I get suggested "@ama[zon]" I press RIGHT to confirm the "zon" completion, at this point search mode should be enabled, I should be able to continue typing, without having to further type another space.
Not entering search mode means that I get "@amazonmysearch" that is definitely not expected, I end up searching the whole string on Google.
If I press Enter instead of Right, it works as expected.

Back to Bug 1658605 Comment 5