The current definition of `virtualMemorySize` in windows/ProcInfo.cpp is set to `PagefileUsage`, which is entirely unrelated to virtual memory size. If we want to find out virtual memory size, it might be better to use `GlobalMemoryStatusEx` and `statex.ullTotalVirtual`. Or we might simply get rid of this statistics because it is useless.
Bug 1659828 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The current definition of `virtualMemorySize` in windows/ProcInfo.cpp is set to `PagefileUsage`, which is entirely unrelated to virtual memory size. If we want to find out virtual memory size, it might be better to use `GlobalMemoryStatusEx` and `statex.ullTotalVirtual`. Or we might simply get rid of this statistics because we have no scenario in which it can be useful in the first place.
The current definition of `virtualMemorySize` in windows/ProcInfo.cpp is set to `PagefileUsage`, which is entirely unrelated to virtual memory size. We should entirely get rid of this statistics on all platforms because we have no scenario in which it can be useful in the first place. If we ever need it, we'll reimplement it correctly. The objective of this bug is to: 1. change the definitions in [ChromeUtils.webidl](https://searchfox.org/mozilla-central/rev/23dd7c485a6525bb3a974abeaafaf34bfb43d76b/dom/chrome-webidl/ChromeUtils.webidl#533-560) to remove field `virtualMemorySize` entirely; 2. during a rebuild, this will cause a number of compilation issues, fix these by removing all instances of `VirtualMemorySize` at the site of errors; 3. fix the test `browser_test_procinfo.js` to remove `virtualMemorySize`.
The current definition of `virtualMemorySize` in windows/ProcInfo.cpp is set to `PagefileUsage`, which is entirely unrelated to virtual memory size. We should entirely get rid of this statistics on all platforms because we have no scenario in which it can be useful in the first place. If we ever need it, we'll reimplement it correctly. The objective of this bug is to: 1. change the definitions of structs in [ChromeUtils.webidl](https://searchfox.org/mozilla-central/rev/23dd7c485a6525bb3a974abeaafaf34bfb43d76b/dom/chrome-webidl/ChromeUtils.webidl#533-560) to remove field `virtualMemorySize` entirely; 2. during a rebuild, this will cause a number of compilation issues, fix these by removing all instances of `VirtualMemorySize` at the site of errors; 3. fix the test `browser_test_procinfo.js` to remove `virtualMemorySize`.