Geoff - the implementation in your patch enables users/programs to easily disable extensions by just setting one environment variable. Is that desirable? If it is not, consider also checking the argv, as the toolbox also includes a unique flag: https://searchfox.org/mozilla-central/rev/73a14f1b367948faa571ed2fe5d7eb29460787c1/devtools/client/framework/browser-toolbox/Launcher.jsm#249-250 ... and also consider adding a regression test to ensure that this continues to work despite potential future refactors.
Bug 1660186 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Geoff - the implementation in your patch enables users/programs to easily disable components by just setting one environment variable. Is that desirable? If it is not, consider also checking the argv, as the toolbox also includes a unique flag: https://searchfox.org/mozilla-central/rev/73a14f1b367948faa571ed2fe5d7eb29460787c1/devtools/client/framework/browser-toolbox/Launcher.jsm#249-250 ... and also consider adding a regression test to ensure that this continues to work despite potential future refactors.