Bug 1660870 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I suspect this may have been caused by this change:
```
-                os.environ.get("MOZHARNESS_TEST_PATHS", '""')
+                os.environ.get("MOZHARNESS_TEST_PATHS", '"{}"')
```

Since if you `json.loads` the former you get `''` (which evaluates to `False`), whereas the latter returns `'{}'` (which evaluates to `True`). So I think this patch was causing us to go into the following if statement even when `MOZHARNESS_TEST_PATHS` was unset. I'm pretty sure all the other WPT suites always pass in `MOZHARNESS_TEST_PATHS`, so that's why they didn't break as well.
Revision 1 by
on 
I suspect this may have been caused by this change:
```diff
-                os.environ.get("MOZHARNESS_TEST_PATHS", '""')
+                os.environ.get("MOZHARNESS_TEST_PATHS", '"{}"')
```

Since if you `json.loads` the former you get `''` (which evaluates to `False`), whereas the latter returns `'{}'` (which evaluates to `True`). So I think this patch was causing us to go into the following if statement even when `MOZHARNESS_TEST_PATHS` was unset. I'm pretty sure all the other WPT suites always pass in `MOZHARNESS_TEST_PATHS`, so that's why they didn't break as well.

Back to Bug 1660870 Comment 16