### Beta/Release Uplift Approval Request
* **User impact if declined**: a) When using Alpenglow, new tab button hard to see in some cases under default Windows theme.
b) When using Alpenglow theme, toolbar looks unpolished/broken in some non-default configurations (menu bar enabled on Windows or Linux)
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: a) visual contrast bug
[Affected Platforms]:
Windows 7 (x32)
Windows 10 (x64)
Ubuntu Linux 18.04
[Prerequisites]:
Have the OS theme set to “Light”.
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the "about:welcome" page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Open 10 “New Tab” pages and observe the “Open a new tab” button.
Observe the “File” toolbar button.
[Expected results]:
6. The “Open a new tab” button is visible.
7. The “File” toolbar button is visible.
[Actual results]:
6. The “Open a new tab” button is barely visible.
7. The “File” toolbar button is barely visible.
[Notes]:
The issue is also reproducible on Ubuntu Linux 18.04.
The issue is not reproducible on macOS 10.15.
Attached a recording of the issue.
b) Broken-looking toolbar issue
[Notes]:
In order to reproduce the issue for some Linux distros, set the browser.tabs.drawinTitlebar pref to true.
[Affected Versions]:
Firefox Beta 81.0b1 (Build ID: 20200824150741)
Firefox Nightly 82.0a1 (Build ID: 20200824215021)
[Affected Platforms]:
Windows 10 (x64)
Linux MX 4.19
Ubuntu Linux 18.04
[Prerequisites]:
Have the “Bookmarks Toolbar” enabled
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the “about:welcome” page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Observe the border line between the displayed page and the “Tab Bar”.
[Expected results]:
The “Firefox Alpenglow” theme color extends to the border line between the displayed page and the “Tab Bar”.
[Actual results]:
There is a white thick line between the border line and “Tab bar”
[Additional Notes]:
The issue is not reproducible on macOS 10.15.
The issue is not reproducible on Windows 7 (x64).
Attached a screenshot of the issue.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: This low risk because it's SVG theme asset changes, so it can't really break much functionality. That said, it's conceivable that it could regress some other theme-related surface. Talked to shorlander (who did the theme changes), and his thought was that the overall risk here is low.
* **String changes made/needed**: None
Bug 1661010 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request
* **User impact if declined**: a) When using Alpenglow, new tab button & file menu hard to see in some cases under default Windows theme.
b) When using Alpenglow theme, toolbar looks unpolished/broken in some non-default configurations (menu bar enabled on Windows or Linux)
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: a) visual contrast bug
[Affected Platforms]:
Windows 7 (x32)
Windows 10 (x64)
Ubuntu Linux 18.04
[Prerequisites]:
Have the OS theme set to “Light”.
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the "about:welcome" page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Open 10 “New Tab” pages and observe the “Open a new tab” button.
Observe the “File” toolbar button.
[Expected results]:
6. The “Open a new tab” button is visible.
7. The “File” toolbar button is visible.
[Actual results]:
6. The “Open a new tab” button is barely visible.
7. The “File” toolbar button is barely visible.
[Notes]:
The issue is also reproducible on Ubuntu Linux 18.04.
The issue is not reproducible on macOS 10.15.
Attached a recording of the issue.
b) Broken-looking toolbar issue
[Notes]:
In order to reproduce the issue for some Linux distros, set the browser.tabs.drawinTitlebar pref to true.
[Affected Versions]:
Firefox Beta 81.0b1 (Build ID: 20200824150741)
Firefox Nightly 82.0a1 (Build ID: 20200824215021)
[Affected Platforms]:
Windows 10 (x64)
Linux MX 4.19
Ubuntu Linux 18.04
[Prerequisites]:
Have the “Bookmarks Toolbar” enabled
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the “about:welcome” page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Observe the border line between the displayed page and the “Tab Bar”.
[Expected results]:
The “Firefox Alpenglow” theme color extends to the border line between the displayed page and the “Tab Bar”.
[Actual results]:
There is a white thick line between the border line and “Tab bar”
[Additional Notes]:
The issue is not reproducible on macOS 10.15.
The issue is not reproducible on Windows 7 (x64).
Attached a screenshot of the issue.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: This low risk because it's SVG theme asset changes, so it can't really break much functionality. That said, it's conceivable that it could regress some other theme-related surface. Talked to shorlander (who did the theme changes), and his thought was that the overall risk here is low.
* **String changes made/needed**: None
### Beta/Release Uplift Approval Request
* **User impact if declined**:
a) When using Alpenglow, new tab button & file menu hard to see in some cases under default Windows theme.
b) When using Alpenglow theme, toolbar looks unpolished/broken in some non-default configurations (menu bar enabled on Windows or Linux)
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: a) visual contrast bug
[Affected Platforms]:
Windows 7 (x32)
Windows 10 (x64)
Ubuntu Linux 18.04
[Prerequisites]:
Have the OS theme set to “Light”.
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the "about:welcome" page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Open 10 “New Tab” pages and observe the “Open a new tab” button.
Observe the “File” toolbar button.
[Expected results]:
6. The “Open a new tab” button is visible.
7. The “File” toolbar button is visible.
[Actual results]:
6. The “Open a new tab” button is barely visible.
7. The “File” toolbar button is barely visible.
[Notes]:
The issue is also reproducible on Ubuntu Linux 18.04.
The issue is not reproducible on macOS 10.15.
Attached a recording of the issue.
b) Broken-looking toolbar issue
[Notes]:
In order to reproduce the issue for some Linux distros, set the browser.tabs.drawinTitlebar pref to true.
[Affected Versions]:
Firefox Beta 81.0b1 (Build ID: 20200824150741)
Firefox Nightly 82.0a1 (Build ID: 20200824215021)
[Affected Platforms]:
Windows 10 (x64)
Linux MX 4.19
Ubuntu Linux 18.04
[Prerequisites]:
Have the “Bookmarks Toolbar” enabled
Have the “Menu Bar” enabled.
[Steps to reproduce]:
Start the Firefox Browser with the profile from prerequisites.
Navigate to the “about:welcome” page.
Click the “Start Setup” button.
Click the “Not now” button.
Select “Firefox Alpenglow” theme.
Observe the border line between the displayed page and the “Tab Bar”.
[Expected results]:
The “Firefox Alpenglow” theme color extends to the border line between the displayed page and the “Tab Bar”.
[Actual results]:
There is a white thick line between the border line and “Tab bar”
[Additional Notes]:
The issue is not reproducible on macOS 10.15.
The issue is not reproducible on Windows 7 (x64).
Attached a screenshot of the issue.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: This low risk because it's SVG theme asset changes, so it can't really break much functionality. That said, it's conceivable that it could regress some other theme-related surface. Talked to shorlander (who did the theme changes), and his thought was that the overall risk here is low.
* **String changes made/needed**: None