Bug 1663583 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Yeah, there's one logical error because "Del" with cursor in position 0 of whitespace-only should first eat up the whitespace before removing the row. Overlooked that when conflating "Backspace" and "Del" which are handled separately in the other function.
Yeah, there's one tiny logical error because "Del" with cursor in position 0 of whitespace-only should first eat up the whitespace before removing the row. Overlooked that when conflating "Backspace" and "Del" which are handled separately in the other function.
Yeah, there's one tiny logical error because "Del" with cursor in position 0 of whitespace-only should first eat up the whitespace before removing the row. ~Overlooked that when conflating "Backspace" and "Del" which are handled separately in the other function.~
Edit: This is how it also works for autocomplete headers. Selected whitespace will get deleted normally with DEL, but if your cursor is in position 0 (meaning you won't even see the following whitespace), we just remove the row. I guess that's ok, because it might feel unresponsive if we first delete the invisible whitespace, and you wouldn't typically position your cursor at position 0 to delete it from front (but rather select it first, or use backspace). It's very unlikely to end up with whitespace only anyway...
We could also copy the trick that starting with a space isn't possible...
~Yeah, there's one tiny logical error because "Del" with cursor in position 0 of whitespace-only should first eat up the whitespace before removing the row. Overlooked that when conflating "Backspace" and "Del" which are handled separately in the other function.~
Edit: This is how it also works for autocomplete headers. Selected whitespace will get deleted normally with DEL, but if your cursor is in position 0 (meaning you won't even see the following whitespace), we just remove the row. I guess that's ok, because it might feel unresponsive if we first delete the invisible whitespace, and you wouldn't typically position your cursor at position 0 to delete it from front (but rather select it first, or use backspace). It's very unlikely to end up with whitespace only anyway...
We could also copy the trick that starting with a space isn't possible...
~Yeah, there's one tiny logical error because "Del" with cursor in position 0 of whitespace-only should first eat up the whitespace before removing the row. Overlooked that when conflating "Backspace" and "Del" which are handled separately in the other function.~
Edit: This is how it also works for autocomplete headers. Selected whitespace will get deleted normally with DEL, but if your cursor is in position 0 (meaning you won't even see the following whitespace), we just remove the row. I guess that's ok, because it might feel unresponsive if we first delete the invisible whitespace, and you wouldn't typically position your cursor at position 0 to delete it from front (but rather select it first, or use backspace). It's very hard and unlikely to end up with whitespace only anyway...
We could also copy the trick that starting with a space isn't possible...

Back to Bug 1663583 Comment 2