Why not fixing EGL? (Darkspirit from comment #10) > WebRender doesn't seem to support HDR yet (bug 1539685): bug 1493198 only added HDR to SDR conversion to WebRender ([Ctrl+F HDR](https://mozillagfx.wordpress.com/2019/08/19/moz-gfx-newsletter-47/)). > > This line requests RGBA8888: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#876 > And this line seems to require RGBA8888 otherwise CreateConfig seems to fail: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 > Could 2 bit alpha be requested and no alpha be required, so that the [RGB10_A2 egl fb config](https://pastebin.com/raw/uTjurKzx) could have matched? That was the only one with alpha on the X11 platform. Does WebRender need to support HDR before doing such a change? EGL allows either RGB656, RGB888 or RGBA8888, otherwise fails to make an EGLconfig. https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 GLX: * GLX::FindVisual might fail because it wants RGBA8888. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#756-761,767 * gdk_screen_get_rgba_visual failed on Nvidia. * GLX wants any fb config that has at least RGBA***8. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#588 https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#786 * Window might not have alpha, therefore no alpha GLX fb config might have matched, so it might fall back to just finding a compatible fb config without enforcing requirements, it might choose RGB888 for WebRender although bug 1663273 wanted to require alpha for WebRender. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#823-840
Bug 1667621 Comment 17 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Why not fixing EGL? (Darkspirit from comment #10) > WebRender doesn't seem to support HDR yet (bug 1539685): bug 1493198 only added HDR to SDR conversion to WebRender ([Ctrl+F HDR](https://mozillagfx.wordpress.com/2019/08/19/moz-gfx-newsletter-47/)). > > This line requests RGBA8888: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#876 > And this line seems to require RGBA8888 otherwise CreateConfig seems to fail: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 > Could 2 bit alpha be requested and no alpha be required, so that the [RGB10_A2 egl fb config](https://pastebin.com/raw/uTjurKzx) could have matched? That was the only one with alpha on the X11 platform. Does WebRender need to support HDR before doing such a change? EGL allows either RGB656, RGB888 or RGBA8888, otherwise fails to make an EGLconfig. https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 GLX: * GLX::FindVisual might fail because it wants RGBA8888. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#756-761,767 * gdk_screen_get_rgba_visual failed on Nvidia. * GLX wants any fb config that has at least RGBA***8 if window depth is 32. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#588 https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#786 * Window might not have alpha, therefore no alpha GLX fb config might have matched, so it might fall back to just finding a compatible fb config without enforcing requirements, it might choose RGB888 for WebRender although bug 1663273 wanted to require alpha for WebRender. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#823-840
Why not fixing EGL? (Darkspirit from comment #10) > WebRender doesn't seem to support HDR yet (bug 1539685): bug 1493198 only added HDR to SDR conversion to WebRender ([Ctrl+F HDR](https://mozillagfx.wordpress.com/2019/08/19/moz-gfx-newsletter-47/)). > > This line requests RGBA8888: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#876 > And this line seems to require RGBA8888 otherwise CreateConfig seems to fail: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 > Could 2 bit alpha be requested and no alpha be required, so that the [RGB10_A2 egl fb config](https://pastebin.com/raw/uTjurKzx) could have matched? That was the only one with alpha on the X11 platform. Does WebRender need to support HDR before doing such a change? EGL allows either RGB565, RGB888 or RGBA8888, otherwise fails to make an EGLconfig. https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 GLX: * GLX::FindVisual might fail because it wants RGBA8888. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#756-761,767 * gdk_screen_get_rgba_visual failed on Nvidia. * GLX wants any fb config that has at least RGBA***8 if window depth is 32. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#588 https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#786 * Window might not have alpha, therefore no alpha GLX fb config might have matched, so it might fall back to just finding a compatible fb config without enforcing requirements, it might choose RGB888 for WebRender although bug 1663273 wanted to require alpha for WebRender. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#823-840
Why not fixing EGL? (Darkspirit from comment #10) > WebRender doesn't seem to support HDR yet (bug 1539685): bug 1493198 only added HDR to SDR conversion to WebRender ([Ctrl+F HDR](https://mozillagfx.wordpress.com/2019/08/19/moz-gfx-newsletter-47/)). > > This line requests RGBA8888: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#876 > And this line seems to require RGBA8888 otherwise CreateConfig seems to fail: https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 > Could 2 bit alpha be requested and no alpha be required, so that the [RGB10_A2 egl fb config](https://pastebin.com/raw/uTjurKzx) could have matched? That was the only one with alpha on the X11 platform. Does WebRender need to support HDR before doing such a change? EGL allows either RGB565, RGB888 or RGBA8888, otherwise fails to make an EGLconfig. https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/gfx/gl/GLContextProviderEGL.cpp#928 GLX: * GLX::FindVisual might fail because it wants RGBA8888. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#756-761,767 * gdk_screen_get_rgba_visual failed on Nvidia. * GLX wants any fb config that has at least RGBA***8 if window depth is 32. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#588 https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#786 * No GLX fb config might have matched, so it might fall back to just finding a compatible fb config without enforcing requirements. https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/gfx/gl/GLContextProviderGLX.cpp#823-840