Bugzilla

I must admit I thoroughly detest the deep internals of the address book - I really feel for Geoff because the way things are nested there is just mind-warping! Our current construct for "All Address Books" looks pretty fragile: returning directory = null for (!uri) but also for (uri==kAllDirectoryRoot aka "moz-abdirectory://") where we really mean "All Address Books" looks like a recipe for errors.
Anyway, I've tried my best to cut through the jungle in my detailed review on phabricator.

https://phabricator.services.mozilla.com/D91884#2998738

I must admit I thoroughly detest the deep internals of the address book - I really feel for Geoff because the way things are nested there is just mind-warping! Our current construct for "All Address Books" looks pretty fragile: returning directory = null for (!uri) but also for (uri==kAllDirectoryRoot aka "moz-abdirectory://") where we really mean "All Address Books" looks like a recipe for errors.
Anyway, I've tried my best to cut through the jungle in my detailed review on phabricator.

https://phabricator.services.mozilla.com/D91884#2998738 (you'll have to scroll down for the yellow comment, as phabricator jumps back to the top after selecting that).

I must admit I thoroughly detest the deep internals of the address book - I really feel for Geoff because the way things are nested in there is just mind-warping! Our current construct for "All Address Books" looks pretty fragile: returning directory = null for (!uri) but also for (uri==kAllDirectoryRoot aka "moz-abdirectory://") where we really mean "All Address Books" looks like a recipe for errors.
Anyway, I've tried my best to cut through the jungle in my detailed review on phabricator.

https://phabricator.services.mozilla.com/D91884#2998738 (you'll have to scroll down for the yellow comment, as phabricator jumps back to the top after selecting that).