> Surrounding code usually keeps if-conditions and method arguments in a single line, while this patch often spreads them out multiple, very short lines. That's the linter. I think that's what Neil referred to with "Ugh, you do insist on making the code less readable...", whereas "you" is presumably the linter/prettier configuration. > Getting a method to add address books is essential for any clean address book provider API (including experiments for individual add-ons) and would be very useful for future core API development Exactly. Splitting this into 2 patches is a compromise, to get something moving forward. > we should merge something along Attachment 9220169 [details] [diff] very soon, to permit all address-book related add-ons to switch to better experiments for the next ESR release Thanks! Yes, that's the goal. For ExQuilla for TB 78, because all ABs are hardcoded in TB 78, we were currently forced to fork (!) and replace the entire TB-internal address book manager. Also in Owl now for the search-only address book. For TB 91, I really really want that fork done. This patch is required to solve it. So, this solves a real and urgent problem. > ASYNC_TYPE should probably be ASYNC_DIRECTORY_TYPE for consistency No problem. We're happy to fix nits.
Bug 1670752 Comment 44 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> Surrounding code usually keeps if-conditions and method arguments in a single line, while this patch often spreads them out multiple, very short lines. That's the linter, see comment 39. > Getting a method to add address books is essential for any clean address book provider API (including experiments for individual add-ons) and would be very useful for future core API development Exactly. Splitting this into 2 patches is a compromise, to get something moving forward. > we should merge something along Attachment 9220169 [details] [diff] very soon, to permit all address-book related add-ons to switch to better experiments for the next ESR release Thanks! Yes, that's the goal. For ExQuilla for TB 78, because all ABs are hardcoded in TB 78, we were currently forced to fork (!) and replace the entire TB-internal address book manager. Also in Owl now for the search-only address book. For TB 91, I really really want that fork done. This patch is required to solve it. So, this solves a real and urgent problem. > ASYNC_TYPE should probably be ASYNC_DIRECTORY_TYPE for consistency No problem. We're happy to fix nits.
> Surrounding code usually keeps if-conditions and method arguments in a single line, while this patch often spreads them out multiple, very short lines. That's the linter, see comment 39. > Getting a method to add address books is essential for any clean address book provider API (including experiments for individual add-ons) and would be very useful for future core API development Exactly. Splitting this into 2 patches is a compromise, to get something moving forward. > we should merge something along Attachment 9220169 [details] [diff] very soon, to permit all address-book related add-ons to switch to better experiments for the next ESR release Thanks! Yes, that's the goal. For ExQuilla for TB 78, because all ABs are hardcoded in TB 78, we were currently forced to fork (!) and replace the entire TB-internal address book manager. Also now in Owl, for the search-only address book. For TB 91, I really really want that fork done. This patch is required to solve it. So, this solves a real and urgent problem. > ASYNC_TYPE should probably be ASYNC_DIRECTORY_TYPE for consistency No problem. We're happy to fix nits.
> Surrounding code usually keeps if-conditions and method arguments in a single line, while this patch often spreads them out multiple, very short lines. That's the linter, see comment 39. > Getting a method to add address books is essential for any clean address book provider API (including experiments for individual add-ons) and would be very useful for future core API development Exactly. Splitting this into 2 patches is a compromise, to get something moving forward. > we should merge something along Attachment 9220169 [details] [diff] very soon, to permit all address-book related add-ons to switch to better experiments for the next ESR release Thanks! Yes, that's the goal. For ExQuilla for TB 78, because all ABs are hardcoded in TB 78, we were currently forced to fork (!) and replace the entire TB-internal address book manager. Also now in Owl, for the search-only address book. For TB 91, I really really want that fork gone. This patch is required to solve it. So, this solves a real and urgent problem. > ASYNC_TYPE should probably be ASYNC_DIRECTORY_TYPE for consistency No problem. We're happy to fix nits.
> Surrounding code usually keeps if-conditions and method arguments in a single line, while this patch often spreads them out multiple, very short lines. That's the linter, see comment 39. > Getting a method to add address books is essential for any clean address book provider API (including experiments for individual add-ons) and would be very useful for future core API development Exactly. Splitting this into 2 patches is a compromise, to get something moving forward. > we should merge something along Attachment 9220169 [details] [diff] very soon, to permit all address-book related add-ons to switch to better experiments for the next ESR release Thanks! Yes, that's the goal. For ExQuilla for TB 78, because all address book implementations were hardcoded in TB 78, with no ability to add one, we were currently forced to fork (!) and replace the entire TB-internal address book manager. Also now in Owl, for the search-only address book. For TB 91, I really really want that fork gone. This patch is required to solve it. So, this solves a real and urgent problem. > ASYNC_TYPE should probably be ASYNC_DIRECTORY_TYPE for consistency No problem. We're happy to fix nits.