Bug 1670949 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I have some comments regarding on this approach. I agree that we should move `./mach clang-format` to `./mach lint`. Even though linting is not a well define behavior for a tool in C/C++ ecosystem, since you can argue that linting performs only `static-analysis` but on the other hand in the `js` world it also performs formatting, what's the case here, we should have a consistent behavior and infrastructure for all our tools that interact with source file as a programming language manipulator.  
Also I have a big objection regarding the way how `clang-format` is currently integrated into `./mach lint`, the process of bootstrapping is non existent right now, so we should take this into account when migrating from the old style to `./mach lint`. At the moment if you have ran C++ static-analysis you will get just a python error saying that `clang-format` binary cannot be located and it doesn't perform actual steps too bootstrap you in a workable environment.
I have some comments regarding this approach. I agree that we should move `./mach clang-format` to `./mach lint`. Even though linting is not a well define behavior for a tool in C/C++ ecosystem, since you can argue that linting performs only `static-analysis` but on the other hand in the `js` world it also performs formatting, what's the case here, we should have a consistent behavior and infrastructure for all our tools that interact with source file as a programming language manipulator.  
Also I have a big objection regarding the way how `clang-format` is currently integrated into `./mach lint`, the process of bootstrapping is non existent right now, so we should take this into account when migrating from the old style to `./mach lint`. At the moment if you have ran C++ static-analysis you will get just a python error saying that `clang-format` binary cannot be located and it doesn't perform actual steps too bootstrap you in a workable environment.

Back to Bug 1670949 Comment 2