Bug 1674302 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

As discussed in the patch stack (particularly https://phabricator.services.mozilla.com/D103435 ), I'm uneasy about just directly using the table's `min-width` and `min-height` as if they were the `min-width` and `min-height` of the table-wrapper, because it means we don't end up setting aside space for the caption, which can then mean we have needlessly-overlapping content.

I suspect in comment 0, mats was just suggesting that we defer to the table-inner-frame **for the purpose of answering certain targeted questions like "is this property auto"** in some specific cases where it makes sense to do so; but not that we should directly using the inner frame's exact specified property min-size/max-size values for sizing the outer frame.

Am I understanding that correctly, mats?

 (I'm also not entirely sure which specific targeted questions it makes sense to defer to the table-inner-frame, offhand -- the link in comment 0 is about `min-width:auto` / `min-height:auto`. I actually think it feels right for that to always be `auto` on the table-wrapper frame, even in cases where the author has specified some min-width/min-height value on the table, since tables don't support being smaller than their content-size anyway; and if the specified value is larger, then we'll still pick that up & honor it when we measure content to resolve the `auto` size on the table wrapper.)
As discussed in the patch stack (particularly https://phabricator.services.mozilla.com/D103435 ), I'm uneasy about just directly using the table's `min-width` and `min-height` as if they were the `min-width` and `min-height` of the table-wrapper, because it means we don't end up setting aside space for the caption, which can then mean we have needlessly-overlapping content.

I suspect in comment 0, mats was just suggesting that we defer to the table-inner-frame **for the purpose of answering certain targeted questions like "is this property auto"** in some specific cases where it makes sense to do so; but not that we should be directly using the inner frame's exact specified property min-size/max-size values for sizing the outer frame (as Part 2 of the patch-stack here kinda does).

Am I understanding that correctly, mats?

 (I'm also not entirely sure which specific targeted questions it makes sense to defer to the table-inner-frame, offhand -- the link in comment 0 is about `min-width:auto` / `min-height:auto`. I actually think it feels right for that to always be `auto` on the table-wrapper frame, even in cases where the author has specified some min-width/min-height value on the table, since tables don't support being smaller than their content-size anyway; and if the specified value is larger, then we'll still pick that up & honor it when we measure content to resolve the `auto` size on the table wrapper.)

Back to Bug 1674302 Comment 11