Bug 1676068 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Sergi Almacellas Abellana from comment #15)
> Hi, 
> 
> I see this improves the datetime popup for `datetime-local` widgets. 
> Does this patch add the time picker so we will be able to pick both date and time widgets? 
> 
> How can I tests this feature? Is available on firefox nightly or should I build it myself to test it? 
> 
> TIA.

Hi Sergi,

The feature is not yet landed, but you are welcome to pull the attached stack of patches and build it locally to test - I am actively working on finalizing it, so while there may be slight changes in the code down the line, but they should not affect the built functionality (i.e. it could resolve some edge cases or refactor test code). I will post here once all the patches are approved and are landing.

This bugwork does not add time picker panel, but I filed [another bug 1802202](https://bugzilla.mozilla.org/show_bug.cgi?id=1802202) to consider flipping the pref `dom.forms.datetime.timepicker` to `true` by default - this would show the time picker on time fields within `<input type=datetime-local>` and `<input type=time>`. Please feel free to comment a thumbs up in there, if you think that would be good to have ;) 

That's being said, the `spinner.js` work done for this bug would drastically improve the a11y of the time picker panel already.
(In reply to Sergi Almacellas Abellana from comment #15)
> Hi, 
> 
> I see this improves the datetime popup for `datetime-local` widgets. 
> Does this patch add the time picker so we will be able to pick both date and time widgets? 
> 
> How can I tests this feature? Is available on firefox nightly or should I build it myself to test it? 
> 
> TIA.

Hi Sergi,

The feature is not yet landed, but you are welcome to pull [the attached stack of patches (link added)](https://phabricator.services.mozilla.com/D142743) and build it locally to test - I am actively working on finalizing it, so while there may be slight changes in the code down the line, but they should not affect the built functionality (i.e. it could resolve some edge cases or refactor test code). I will post here once all the patches are approved and are landing.

This bugwork does not add time picker panel, but I filed [another bug 1802202](https://bugzilla.mozilla.org/show_bug.cgi?id=1802202) to consider flipping the pref `dom.forms.datetime.timepicker` to `true` by default - this would show the time picker on time fields within `<input type=datetime-local>` and `<input type=time>`. Please feel free to comment a thumbs up in there, if you think that would be good to have ;) 

That's being said, the `spinner.js` work done for this bug would drastically improve the a11y of the time picker panel already.
(In reply to Sergi Almacellas Abellana from comment #15)
> Hi, 
> 
> I see this improves the datetime popup for `datetime-local` widgets. 
> Does this patch add the time picker so we will be able to pick both date and time widgets? 
> 
> How can I tests this feature? Is available on firefox nightly or should I build it myself to test it? 
> 
> TIA.

Hi Sergi,

The feature is not yet landed, but you are welcome to pull [the attached stack of patches](https://phabricator.services.mozilla.com/D142743) and build it locally to test - I am actively working on finalizing it, so while there may be slight changes in the code down the line, but they should not affect the built functionality (i.e. it could resolve some edge cases or refactor test code). I will post here once all the patches are approved and are landing.

This bugwork does not add time picker panel, but I filed [another bug 1802202](https://bugzilla.mozilla.org/show_bug.cgi?id=1802202) to consider flipping the pref `dom.forms.datetime.timepicker` to `true` by default - this would show the time picker on time fields within `<input type=datetime-local>` and `<input type=time>`. Please feel free to comment a thumbs up in there, if you think that would be good to have ;) 

That's being said, the `spinner.js` work done for this bug would drastically improve the a11y of the time picker panel already.

(Updated to add a phab link)

Back to Bug 1676068 Comment 16