(In reply to Magnus Melin [:mkmelin] from comment #13) > There's not necessarily one single right answer that covers all cases. For cases where it's not purely for design, But that will be the case for the very large majority of conversions. It is the case for both the patch checked in and the patch queued up. Using ```src``` for the editContactPanel panel star is the least correct and efficient way to do it. Tb should follow Emilio's suggestion in Bug 1584641 for ```content``` else use ```background-image```. > Cases where things wouldn't work correctly if the image is missing or couldn't load. > It's quite conceivable we'd load the pages also through other means than internal chrome some time in the future, and there could then be some possibility an image didn't load due to networking errors or similar. > There is no legitimate scenario for missing image to be true for internal pages and I don't see how remote loading is conceivable at all; no one would propose such a thing for a desktop app. Some hypothetical thunderbird on the web scenario is not relevant here, and even then would be delivered via a font library with unicode private area definitions using ```content```, like the tag button on this page. > <img src> can be overridden in css if desired - see http://www.audenaerde.org/csstricks.html#imagereplacecss Sure, that is what's called a paper-over masking hack, not an override.
Bug 1683865 Comment 14 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Magnus Melin [:mkmelin] from comment #13) > There's not necessarily one single right answer that covers all cases. For cases where it's not purely for design, But that will be the case for the very large majority of conversions. It is the case for both the patch checked in and the patch queued up. Using ```src``` for the editContactPanel panel star is the least correct and efficient way to do it. Tb should follow Emilio's suggestion in Bug 1584641 for ```content``` else use ```background-image```. > Cases where things wouldn't work correctly if the image is missing or couldn't load. > It's quite conceivable we'd load the pages also through other means than internal chrome some time in the future, and there could then be some possibility an image didn't load due to networking errors or similar. > There is no legitimate scenario for missing image to be true for internal pages and I don't see how remote loading is conceivable at all; no one would propose such a thing for a desktop app. Some hypothetical thunderbird on the web scenario is not relevant here, and even then would be delivered via a font library with unicode private area definitions using ```content```, like the tag button on this page. > <img src> can be overridden in css if desired - see http://www.audenaerde.org/csstricks.html#imagereplacecss Sure, that is what's called a paper-over masking hack, not an override.