Bug 1688019 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I was thinking of picking this up, but I feel like I need more info to know how to move forward.

If I'm understanding this correctly, the issue is that target url is also contained in the Google search results URL. So if the user happens to type a string that matches both the target URL as well as something in the source URL, then source link may show up in suggest. 

Other providers (i.e. Bing) may also use redirects but they may not be including the target URL in the request URL, so we avoid these duplicate entries.

I feel like I should know how URL's are added to history. There are times when I visit a link that redirects but it doesn't appear in my list of recent history. Thus I think it's worth investigating the process of adding a link to history. I'm going to needsinfo you :mak because you probably have a quick answer to this (and more insight) but I'll be doing investigation to gain a better understanding in the meantime.

Not that this is the solution, but I know with `onLocationChange` the request can contain an `originalURI` used to make the request. And we also have `aLocation` which is the current URI. They could be used to compare against one another.
I was thinking of picking this up, but I feel like I need more info to know how to move forward.

If I'm understanding this correctly, the issue is that target url is also contained in the Google search results URL. So if the user happens to type a string that matches both the target URL as well as something in the source URL, then source link may show up in suggest. 

Other providers (i.e. Bing) may also use redirects but they may not be including the target URL in the request URL, so we avoid these duplicate entries.

I feel like I should know how URL's are added to history. There are times when I visit a link that redirects but it doesn't appear in my list of recent history. Thus I think it's worth investigating the process of adding a link to history. I'm going to needsinfo you :mak because you probably have a quick answer to this (and more insight).

I feel into the weeds and stepped through the backend logic of adding URI visits which called `VisitURI` in [History.cpp](https://searchfox.org/mozilla-central/rev/8a2d8d26e25ef70c98c6036612aad534b76b9815/toolkit/components/places/History.cpp#1878). Will do more testing to see how the behaviour of this method changes depending on the conditions.

Back to Bug 1688019 Comment 4