Bug 1688476 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors. I have no idea how to fix that in our c-c.

There are still 5 tests failing.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the addressbook, as this.browser is not defined. I have no idea how to fix that in our c-c.

There are still 5 tests failing.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the addressbook, as this.browser is not defined. I have no idea how to fix that in our c-c.

There are still 5 tests failing due to other issues.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` if the function fails for any reason. I have no idea how to fix that in c-c.

The following tests are still failing due to other issues:
- [browser_ext_browserAction.js]
- [browser_ext_commands_execute_browser_action.js]
- [browser_ext_commands_getAll.js]
- [browser_ext_commands_onCommand.js]
- [browser_ext_commands_update.js]
- [browser_ext_composeAction.js]
- [browser_ext_messageDisplayAction.js]
- [browser_ext_tabs_content.js]
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` if the function fails for any reason. I have no idea how to fix that in c-c.

The following tests are still failing due to other issues:
- [browser_ext_browserAction.js]
  fails on unloading
- [browser_ext_commands_execute_browser_action.js]
- [browser_ext_commands_getAll.js]
- [browser_ext_commands_onCommand.js]
- [browser_ext_commands_update.js]
- [browser_ext_composeAction.js]
- [browser_ext_messageDisplayAction.js]
- [browser_ext_tabs_content.js]
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` if the function fails for any reason. I have no idea how to fix that in c-c.

The following tests are still failing due to other issues:
- [browser_ext_commands_execute_browser_action.js]
- [browser_ext_commands_getAll.js]
- [browser_ext_commands_onCommand.js]
- [browser_ext_commands_update.js]
- [browser_ext_tabs_content.js]
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` if the function fails for any reason. I have no idea how to fix that in c-c.

The following tests are still failing due to other issues:
- [browser_ext_tabs_content.js]
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` if the function fails for any reason. I have no idea how to fix that in c-c.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` in my debug patch, if the function fails for any reason.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs and our address book.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for most tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` in my debug patch, if the function fails for any reason.
Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add `title: null` to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new   get matchesHostPermission() function fails when checking our `editor#content-frame` tabs and our address book.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for `this.browser.currentURI.spec` I get `about:blank?compose`, checking `this._url` returns `undefined`, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing `this._url` by `this.browser.currentURI.spec` fixes these errors for the editor tabs, but not for the address book, as `this.browser` is not defined. To fix this I just return `false` in my debug patch, if the function fails for any reason.

Back to Bug 1688476 Comment 2