Bug 1690370 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is racing on the value of mShuttingDown, although weirdly in this case both threads are setting it to true? So pretty benign but potentially an indication that something more scary could be happening.

Naive fix is to just make mShuttingDown atomic.

Permalink to problematic lines:

[NullifyConsumeBodyPump](https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/dom/base/BodyConsumer.h#87)

[BodyConsumer::Create](https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/dom/base/BodyConsumer.cpp#302)
This is racing on the value of mShuttingDown, although weirdly in this case both threads are setting it to true? So pretty benign but potentially an indication that something more scary could be happening.

Naive fix is to just make mShuttingDown atomic.

Permalink to problematic lines:

[NullifyConsumeBodyPump](https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/dom/base/BodyConsumer.h#87)

vs

[BodyConsumer::Create](https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/dom/base/BodyConsumer.cpp#302)

Back to Bug 1690370 Comment 1