Hey Gijs should [Bookmark This Page](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#98-101) and [Bookmark This Frame](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#392-394) be updated to match the `Bookmark Link` item resulting from this patch? i.e., to `Bookmark Page` and `Bookmark Frame`. Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis? The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled `Add Bookmark…` and `Edit Bookmark…` that open the same edit bookmark dialog that the `Bookmark Link` menuitem opens. The [Bookmark Tab](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/tabContextMenu.ftl#57-59) menuitem in the tab context menu, the [Bookmark current tab/Edit this bookmark](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browser.ftl#654-655,672-673) toolbarbutton in the bookmarks subview in the app menu, and the [equivalent menuitems](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/menubar.ftl#221-224) in the menubar's "Bookmarks" menu, are also lacking an ellipsis.
Bug 1690561 Comment 14 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hey Gijs should [Bookmark This Page](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#98-101) and [Bookmark This Frame](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#392-394) be updated to match the `Bookmark Link` item resulting from this patch? i.e., to `Bookmark Page` and `Bookmark Frame`. Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems. The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled `Add Bookmark…` and `Edit Bookmark…` that open the same edit bookmark dialog that the `Bookmark Link` menuitem opens. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis? The [Bookmark Tab](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/tabContextMenu.ftl#57-59) menuitem in the tab context menu, the [Bookmark current tab/Edit this bookmark](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browser.ftl#654-655,672-673) toolbarbutton in the bookmarks subview in the app menu, and the [equivalent menuitems](https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/menubar.ftl#221-224) in the menubar's "Bookmarks" menu, are also lacking an ellipsis.
Hey Gijs should [Bookmark This Page](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#98-101) and [Bookmark This Frame](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#392-394) be updated to match the `Bookmark Link` item resulting from this patch? i.e., to `Bookmark Page` and `Bookmark Frame`. Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems. The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled `Add Bookmark…` and `Edit Bookmark…` that open the same edit bookmark dialog that the `Bookmark Link` menuitem opens. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis? The [Bookmark Tab](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/tabContextMenu.ftl#57-59) menuitem in the tab context menu, the [Bookmark current tab/Edit this bookmark](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browser.ftl#654-655,672-673) toolbarbutton in the bookmarks subview in the app menu, and the [equivalent menuitems](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/menubar.ftl#221-224) in the menubar's "Bookmarks" menu, are also lacking an ellipsis.
Hey Gijs should [Bookmark This Page](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#98-101) and [Bookmark This Frame](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browserContext.ftl#392-394) be updated to match the `Bookmark Link` item resulting from this patch? i.e., to `Bookmark Page` and `Bookmark Frame`. Also do you have an opinion about whether these bookmark menuitems should have ellipses at the end? Francesco noticed that the new bookmark menuitem we just added to the Synced Tabs sidebar context menu is lacking an ellipsis, and I was digging through the equivalent strings and noticed a whole bunch of inconsistencies with bookmark-adding menuitems. The ones that open an edit bookmark dialog or the edit bookmark panel, that is. It kinda sticks out since in the places menus, if you right-click a bookmark you get menuitems labeled `Add Bookmark…` and `Edit Bookmark…` that open the same edit bookmark dialog that the `Bookmark Link` menuitem opens. So, I thought I might open a new bug for this, unless there's a rationale for omitting the ellipsis? The [Bookmark Tab](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/tabContextMenu.ftl#57-59) menuitem in the tab context menu, the [Bookmark current tab/Edit this bookmark](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/browser.ftl#654-655,672-673) toolbarbutton in the bookmarks subview in the app menu, and the [equivalent menuitems](https://searchfox.org/mozilla-central/rev/a8bd595d93203a7e836f4160a458c976b1232143/browser/locales/en-US/browser/menubar.ftl#221-224) in the menubar's "Bookmarks" menu, are also lacking an ellipsis. Edit: oh, and this is unrelated but just making a note so I don't forget — "Print Selection" is also lacking an ellipsis, whereas "Print…" always has one.