Bugzilla

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #6)
> The bookmark icon is being taken care of in bug 1691993. This bug will take care of:
> 
> * browser/themes/shared/icons/menus/reload.svg (reload.svg)
> * browser/themes/shared/icons/menus/back.svg (back.svg)
> * browser/themes/shared/icons/menus/forward.svg (forward.svg)

I think I told you this in matrix, but for completeness on this bug: These icons should just match the toolbar - we should be able to remove the additional menu icons and the CSS at https://searchfox.org/mozilla-central/source/browser/themes/windows/browser.css#861-873 . As you said, the bookmark icon is being replaced in 1691993, and the reload one in bug 1702281. We might not want to land a patch for this bug until both 1702281 and 1691993 are on autoland, as verification of the fix will be confusing if the right icons aren't yet in place.

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #6)
> The bookmark icon is being taken care of in bug 1691993. This bug will take care of:
> 
> * browser/themes/shared/icons/menus/reload.svg (reload.svg)
> * browser/themes/shared/icons/menus/back.svg (back.svg)
> * browser/themes/shared/icons/menus/forward.svg (forward.svg)

I think I told you this in matrix, but for completeness on this bug: These icons should just match the toolbar - we should be able to remove the additional menu icons and the CSS at https://searchfox.org/mozilla-central/source/browser/themes/windows/browser.css#861-873 , as then we'll fall back on the icons specified at https://searchfox.org/mozilla-central/rev/759872688df15a5d6ab305ffe39d90450590bfec/browser/themes/shared/contextmenu.inc.css#23-46 . As you said, the bookmark icon is being replaced in 1691993, and the reload one in bug 1702281. We might not want to land a patch for this bug until both 1702281 and 1691993 are on autoland, as verification of the fix will be confusing if the right icons aren't yet in place.