Bug 1696267 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

STR

1. Do a search for "testing"
2. Type "testing" again but don't hit enter
3. Verify that your "testing" search history is not shown
4. Type a trailing space

The "testing" search history is shown again, but it shouldn't be.

AFAICT we don't properly deupe remote suggestions in this context either, but it's unlikely an engine would actually return a suggestion that is the trimmed version of the search string.

Adrian found this in bug 1694237 comment 12. It should be an easy fix, so I'll go ahead and do it now.

This is not a (recent) regression and goes back to at least 78 according to Adrian.
STR

1. Do a search for "testing"
2. Type "testing" again but don't hit enter
3. Verify that your "testing" search history is not shown
4. Type a trailing space

The "testing" search history is shown again, but it shouldn't be.

AFAICT we don't properly dedupe remote suggestions in this context either, but it's unlikely an engine would actually return a suggestion that is the trimmed version of the search string.

Adrian found this in bug 1694237 comment 12. It should be an easy fix, so I'll go ahead and do it now.

This is not a (recent) regression and goes back to at least 78 according to Adrian.

Back to Bug 1696267 Comment 0