Bugzilla

I'm answering here to the comments on Phabricator as I just found out that it hides "old" comments.

> Note: DNS SRV are not trustable. If it's not the same domain, we need to make sure we don't send creds before the user confirms. I didn't check if we do this or not now...

I'm passing the hostname for calendar and address book detection, alongside the password if the user wrote it, otherwise the dialog with a password prompt will appear. I'm not relying on DNS SRV.

> You can now use this account in Daily!
For a better experience, you will want to connect related services as well.

Sounds a bit, but I like the direction. What about this?
**You can now use this account with { -brand-short-name }.
Connected related services and configure account options for a better experience.**

> Create address book: let's not add this. In general people should not create more *local* address books unless they really know what they are doing.
Create calendar: should probably read Create New Calendar. But... I think it would be better if we have that last in the Calendars section. Similarly there should be a way to manually add address books even if they weren't found. This could also be last in the Address book sections. This should allow adding an LDAP address book as well.

All right, I'll need to completely change the UI of this last section as I wasn't showing it entirely if no AB or Cal were found.
I will show this section regardless, and update the UI to only reflect if we found connected services.
Buttons to create an AB or Cal will be available underneath the related sections.

> In general, I'm not sure we want to use the word synchronize here or in the header. It could be better to say "connect". Synchronize souds a bit much like it's a one time thing, which makes it way less appealing.
This could also make the wording better for the header, for the case where we don't find anything. "Synchronize your linked services" could read "Connect other services"

Sounds good.

> The calendar "synchronize" buttons do not work. (js error in console)

Yes, I wrote in the original comment in Phab about that feature not being done yet.

> Anyway, perhaps it's better to have them be pre-checked checkboxes and if you click through you're automatically set up with them all?

I'm not a fan of checkboxes as it's not immediately clear how to use them.
The user might assume that simply checking them and clicking "Finish" will set up everything, but I'd like to avoid that.
The "Finish" button should only close the tab and post a message to the main window, without doing any configuration.
I'd like to keep the setup of calendars and address book within the page via dedicated buttons, or with the "Connect all" button if the user wants.
Doing this allows us to show a "Done" feedback when something is properly connected. By using the checkboxes we would lose that and the user wouldn't know if the setup was successful or not unless they go around the app looking for those services.

> Skip the "set up another account" - I don't think that's a very common, and if you do it atm you're totally lost and can't go back.

Are you sure? That link simply resets the tab to restart the account setup.
It might be an edge case, but it's convenient if the user needs to add 2 or 3 email accounts all at once without needing to close the tab and reopen it.
I don't have a strong opinion on this, so if you think that link is redundant I'm okay with removing it.

> "Finish" right aligned?

I think it's better to keep it centered.
We're using right aligned button for all the steps of the account setup, so having a final centered button is more indicative of a final and ultimate action, rather than an expectation of a potential next step.

I'm answering here to the comments on Phabricator as I just found out that it hides "old" comments.

> Note: DNS SRV are not trustable. If it's not the same domain, we need to make sure we don't send creds before the user confirms. I didn't check if we do this or not now...

I'm passing the hostname for calendar and address book detection, alongside the password if the user wrote it, otherwise the dialog with a password prompt will appear. I'm not relying on DNS SRV.

> You can now use this account in Daily!
For a better experience, you will want to connect related services as well.

Sounds a bit strange, but I like the direction. What about this?
**You can now use this account with { -brand-short-name }.
Connected related services and configure account options for a better experience.**

> Create address book: let's not add this. In general people should not create more *local* address books unless they really know what they are doing.
Create calendar: should probably read Create New Calendar. But... I think it would be better if we have that last in the Calendars section. Similarly there should be a way to manually add address books even if they weren't found. This could also be last in the Address book sections. This should allow adding an LDAP address book as well.

All right, I'll need to completely change the UI of this last section as I wasn't showing it entirely if no AB or Cal were found.
I will show this section regardless, and update the UI to only reflect if we found connected services.
Buttons to create an AB or Cal will be available underneath the related sections.

> In general, I'm not sure we want to use the word synchronize here or in the header. It could be better to say "connect". Synchronize souds a bit much like it's a one time thing, which makes it way less appealing.
This could also make the wording better for the header, for the case where we don't find anything. "Synchronize your linked services" could read "Connect other services"

Sounds good.

> The calendar "synchronize" buttons do not work. (js error in console)

Yes, I wrote in the original comment in Phab about that feature not being done yet.

> Anyway, perhaps it's better to have them be pre-checked checkboxes and if you click through you're automatically set up with them all?

I'm not a fan of checkboxes as it's not immediately clear how to use them.
The user might assume that simply checking them and clicking "Finish" will set up everything, but I'd like to avoid that.
The "Finish" button should only close the tab and post a message to the main window, without doing any configuration.
I'd like to keep the setup of calendars and address book within the page via dedicated buttons, or with the "Connect all" button if the user wants.
Doing this allows us to show a "Done" feedback when something is properly connected. By using the checkboxes we would lose that and the user wouldn't know if the setup was successful or not unless they go around the app looking for those services.

> Skip the "set up another account" - I don't think that's a very common, and if you do it atm you're totally lost and can't go back.

Are you sure? That link simply resets the tab to restart the account setup.
It might be an edge case, but it's convenient if the user needs to add 2 or 3 email accounts all at once without needing to close the tab and reopen it.
I don't have a strong opinion on this, so if you think that link is redundant I'm okay with removing it.

> "Finish" right aligned?

I think it's better to keep it centered.
We're using right aligned button for all the steps of the account setup, so having a final centered button is more indicative of a final and ultimate action, rather than an expectation of a potential next step.

I'm answering here to the comments on Phabricator as I just found out that it hides "old" comments.

> Note: DNS SRV are not trustable. If it's not the same domain, we need to make sure we don't send creds before the user confirms. I didn't check if we do this or not now...

I'm passing the hostname for calendar and address book detection, alongside the password if the user wrote it, otherwise the dialog with a password prompt will appear. I'm not relying on DNS SRV.

> You can now use this account in Daily!
For a better experience, you will want to connect related services as well.

Sounds a bit strange, but I like the direction. What about this?
**You can now use this account with { -brand-short-name }.
Connect related services and configure account options for a better experience.**

> Create address book: let's not add this. In general people should not create more *local* address books unless they really know what they are doing.
Create calendar: should probably read Create New Calendar. But... I think it would be better if we have that last in the Calendars section. Similarly there should be a way to manually add address books even if they weren't found. This could also be last in the Address book sections. This should allow adding an LDAP address book as well.

All right, I'll need to completely change the UI of this last section as I wasn't showing it entirely if no AB or Cal were found.
I will show this section regardless, and update the UI to only reflect if we found connected services.
Buttons to create an AB or Cal will be available underneath the related sections.

> In general, I'm not sure we want to use the word synchronize here or in the header. It could be better to say "connect". Synchronize souds a bit much like it's a one time thing, which makes it way less appealing.
This could also make the wording better for the header, for the case where we don't find anything. "Synchronize your linked services" could read "Connect other services"

Sounds good.

> The calendar "synchronize" buttons do not work. (js error in console)

Yes, I wrote in the original comment in Phab about that feature not being done yet.

> Anyway, perhaps it's better to have them be pre-checked checkboxes and if you click through you're automatically set up with them all?

I'm not a fan of checkboxes as it's not immediately clear how to use them.
The user might assume that simply checking them and clicking "Finish" will set up everything, but I'd like to avoid that.
The "Finish" button should only close the tab and post a message to the main window, without doing any configuration.
I'd like to keep the setup of calendars and address book within the page via dedicated buttons, or with the "Connect all" button if the user wants.
Doing this allows us to show a "Done" feedback when something is properly connected. By using the checkboxes we would lose that and the user wouldn't know if the setup was successful or not unless they go around the app looking for those services.

> Skip the "set up another account" - I don't think that's a very common, and if you do it atm you're totally lost and can't go back.

Are you sure? That link simply resets the tab to restart the account setup.
It might be an edge case, but it's convenient if the user needs to add 2 or 3 email accounts all at once without needing to close the tab and reopen it.
I don't have a strong opinion on this, so if you think that link is redundant I'm okay with removing it.

> "Finish" right aligned?

I think it's better to keep it centered.
We're using right aligned button for all the steps of the account setup, so having a final centered button is more indicative of a final and ultimate action, rather than an expectation of a potential next step.

I'm answering here to the comments on Phabricator as I just found out that it hides "old" comments.

> Note: DNS SRV are not trustable. If it's not the same domain, we need to make sure we don't send creds before the user confirms. I didn't check if we do this or not now...

I'm passing the hostname for calendar and address book detection, alongside the password if the user wrote it, otherwise the dialog with a password prompt will appear. I'm not relying on DNS SRV.

> You can now use this account in Daily!
For a better experience, you will want to connect related services as well.

Sounds a bit strange, but I like the direction. What about this?
**You can now use this account with { -brand-short-name }.
Connect related services and configure account options for a better experience.**

> Create address book: let's not add this. In general people should not create more *local* address books unless they really know what they are doing.
Create calendar: should probably read Create New Calendar. But... I think it would be better if we have that last in the Calendars section. Similarly there should be a way to manually add address books even if they weren't found. This could also be last in the Address book sections. This should allow adding an LDAP address book as well.

All right, I'll need to completely change the UI of this last section as I wasn't showing it entirely if no AB or Cal were found.
I will show this section regardless, and update the UI to only reflect if we found connected services.
Buttons to create an AB or Cal will be available underneath the related sections.

> In general, I'm not sure we want to use the word synchronize here or in the header. It could be better to say "connect". Synchronize souds a bit much like it's a one time thing, which makes it way less appealing.
This could also make the wording better for the header, for the case where we don't find anything. "Synchronize your linked services" could read "Connect other services"

Sounds good.

> The calendar "synchronize" buttons do not work. (js error in console)

Yes, I wrote in the original comment in Phab about that feature not being done yet.

> Anyway, perhaps it's better to have them be pre-checked checkboxes and if you click through you're automatically set up with them all?

I'm not a fan of checkboxes as it's not immediately clear how to use them.
The user might assume that simply checking them and clicking "Finish" will set up everything, but I'd like to avoid that.
The "Finish" button should only close the tab and post a message to the main window, without doing any configuration.
I'd like to keep the setup of calendars and address book within the page via dedicated buttons, or with the "Connect all" button if the user wants.
Doing this allows us to show a "Done" feedback when something is properly connected. By using the checkboxes we would lose that and the user wouldn't know if the setup was successful or not unless they go around the app looking for those services.

> Skip the "set up another account" - I don't think that's a very common, and if you do it atm you're totally lost and can't go back.

Are you sure? That link simply resets the tab to restart the account setup.
It might be an edge case, but it's convenient if the user needs to add 2 or 3 email accounts all at once without needing to close the tab and reopen it.
I don't have a strong opinion on this, so if you think that link is redundant I'm okay with removing it.

> "Finish" right aligned?

I think it's better to keep it centered.
We're using right aligned buttons for all the steps of the account setup, so having a final centered button is more indicative of a final and ultimate action, rather than an expectation of a potential next step.