Bug 1698814 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Example for --lwt-toolbar-field-background-color
Default theme:
```
// browser.css:
:root {
  --toolbar-field-background-color: Field;
}
:root:-moz-lwtheme {
  --toolbar-field-background-color: <fallback-for-lwtheme>; // I think it's reasonable to remove the fallback hover state for lwtheme, since the default theme doesn't have it.
}

// browser-custom-colors.css:
:root {
  --toolbar-field-background-color: <default-proton-background>;
}
```

--toolbar-field-non-lwt-bgcolor & --lwt-toolbar-field-background-color can both removed for this specific case.

I'm sure more can be done with other --lwt-toolbar-field-* vars.
Revision 1 by
on 
Example for --lwt-toolbar-field-background-color

```
// browser.css:
:root {
  --toolbar-field-background-color: Field;
}
:root:-moz-lwtheme {
  --toolbar-field-background-color: <fallback-for-lwtheme>; // I think it's reasonable to remove the fallback hover state for lwtheme, since the default theme doesn't have it.
}

// browser-custom-colors.css:
:root {
  --toolbar-field-background-color: <default-proton-background>;
}
```

--toolbar-field-non-lwt-bgcolor & --lwt-toolbar-field-background-color can both removed for this specific case.

I'm sure more can be done with other --lwt-toolbar-field-* vars.
Revision 2 by
on 
Example for --lwt-toolbar-field-background-color

```
// browser.css:
:root {
  --toolbar-field-background-color: Field;
}
:root:-moz-lwtheme {
  --toolbar-field-background-color: <fallback-for-lwtheme>; // I think it's reasonable to remove the fallback hover state for lwtheme, since the default theme doesn't have it.
}

// browser-custom-colors.css:
:root {
  --toolbar-field-background-color: <default-proton-background>;
}

// Update LightweightThemeConsumer/ThemeVariableMap:
https://searchfox.org/mozilla-central/rev/b3b6a9b1d0f54b8a432f11ced9283bd43b434bb0/toolkit/modules/LightweightThemeConsumer.jsm#110
```

--toolbar-field-non-lwt-bgcolor & --lwt-toolbar-field-background-color can both removed for this specific case.

I'm sure more can be done with other --lwt-toolbar-field-* vars.
Revision 3 by
on 
Example for --lwt-toolbar-field-background-color

```
// browser.css:
:root {
  --toolbar-field-background-color: Field;
}
:root:-moz-lwtheme {
  --toolbar-field-background-color: <fallback-for-lwtheme>; // I think it's reasonable to remove the fallback hover state for lwtheme, since the default theme doesn't have it.
}

// browser-custom-colors.css:
:root {
  --toolbar-field-background-color: <default-proton-background>;
}

// Update LightweightThemeConsumer/ThemeVariableMap to refer to --toolbar-field-background-color:
https://searchfox.org/mozilla-central/rev/b3b6a9b1d0f54b8a432f11ced9283bd43b434bb0/toolkit/modules/LightweightThemeConsumer.jsm#110
```

--toolbar-field-non-lwt-bgcolor & --lwt-toolbar-field-background-color can both removed for this specific case.

I'm sure more can be done with other --lwt-toolbar-field-* vars.

Back to Bug 1698814 Comment 0