Bug 1699276 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

+++ This bug was initially created as a clone of Bug #1699273 +++

_Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up._ 

## Background
The [`JSID_IS_ATOM` ](https://searchfox.org/mozilla-central/rev/b7b156e53643f0237f3e98a76e5fc7fa9e3b4e71/js/src/jsfriendapi.h#582,585) calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, at internally to the engine. 

## This Bug
This bug is about removing uses of `JSID_IS_ATOM` within the `js/src/debugger` files. Instead of using `JSID_IS_ATOM` we should be using [`JS::PropertyKey::isAtom`]( https://searchfox.org/mozilla-central/source/js/public/Id.h#158-163), which is actually how `JSID_IS_ATOM` is implemented. 

## Prerequisites

Before getting started, you'll want to

* You Have a checkout of the Firefox source code 
* Make sure you can [build and test SpiderMonkey](https://firefox-source-docs.mozilla.org/js/build.html)
* Read [this walkthrough](https://moz-conduit.readthedocs.io/en/latest/walkthrough.html) about how development works in Firefox

## Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the [#spidermonkey channel on chat.mozilla.org](https://chat.mozilla.org/#/room/#spidermonkey:mozilla.org). 

## Tips: 

* Not sure if the code you've been editing is getting run? Insert a call to `MOZ_CRASH`, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!
+++ This bug was initially created as a clone of Bug #1699273 +++

_Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up._ 

## Background
The [`JSID_IS_ATOM` ](https://searchfox.org/mozilla-central/rev/b7b156e53643f0237f3e98a76e5fc7fa9e3b4e71/js/src/jsfriendapi.h#582,585) calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, at internally to the engine. 

## This Bug
This bug is about removing uses of `JSID_IS_ATOM` within the `js/src/debugger` files. Instead of using `JSID_IS_ATOM` we should be using [`JS::PropertyKey::isAtom`]( https://searchfox.org/mozilla-central/source/js/public/Id.h#158-163), which is actually how `JSID_IS_ATOM` is implemented. 

## Prerequisites

Before getting started, you'll want to

* You Have a checkout of the Firefox source code 
* Make sure you can [build and test SpiderMonkey](https://firefox-source-docs.mozilla.org/js/build.html)
* Read [this walkthrough](https://moz-conduit.readthedocs.io/en/latest/walkthrough.html) about how development works in Firefox

## How you’ll know you’re done
* The use of `JSID_IS_ATOM` is removed
* SpiderMonkey builds
* The tests run successfully. 

## Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the [#spidermonkey channel on chat.mozilla.org](https://chat.mozilla.org/#/room/#spidermonkey:mozilla.org). 

## Tips: 

* Not sure if the code you've been editing is getting run? Insert a call to `MOZ_CRASH`, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!
+++ This bug was initially created as a clone of Bug #1699273 +++

_Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up._ 

## Background
The [`JSID_IS_ATOM` ](https://searchfox.org/mozilla-central/rev/b7b156e53643f0237f3e98a76e5fc7fa9e3b4e71/js/src/jsfriendapi.h#582,585) calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, internally to the engine. 

## This Bug
This bug is about removing uses of `JSID_IS_ATOM` within the `js/src/debugger` files. Instead of using `JSID_IS_ATOM` we should be using [`JS::PropertyKey::isAtom`]( https://searchfox.org/mozilla-central/source/js/public/Id.h#158-163), which is actually how `JSID_IS_ATOM` is implemented. 

## Prerequisites

Before getting started, you'll want to

* You Have a checkout of the Firefox source code 
* Make sure you can [build and test SpiderMonkey](https://firefox-source-docs.mozilla.org/js/build.html)
* Read [this walkthrough](https://moz-conduit.readthedocs.io/en/latest/walkthrough.html) about how development works in Firefox

## How you’ll know you’re done
* The use of `JSID_IS_ATOM` is removed
* SpiderMonkey builds
* The tests run successfully. 

## Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the [#spidermonkey channel on chat.mozilla.org](https://chat.mozilla.org/#/room/#spidermonkey:mozilla.org). 

## Tips: 

* Not sure if the code you've been editing is getting run? Insert a call to `MOZ_CRASH`, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!

Back to Bug 1699276 Comment 0