Note: since comment 2, we've added two new calls to this API: - One call in DisplayPortUtils.cpp, in `GetRootDisplayportBase`: https://searchfox.org/mozilla-central/rev/9759c03110173c8cf62ba0de21aa9b06b850c794/layout/base/DisplayPortUtils.cpp#1201 - One call call in ViewportUtils.cpp, in `TryInferEnclosingResolution`: https://searchfox.org/mozilla-central/rev/9759c03110173c8cf62ba0de21aa9b06b850c794/layout/base/ViewportUtils.cpp#264 Fortunately I think both of these are fine. Both of these were added in recent commits authored/reviewed by folks working on fission audits (author:hiro, botond; reviewed by: tnikkel/hiro), in patches that were specifically about OOP child frames. So, I think it's safe to assume those callsites have already been vetted as being fine in a fission world. (Also, they're in assertions -- i.e. not in user-affecting logic). Beyond that, the above comments have covered all of the existing callsites (comment 2, comment 3, comment 5, comment 6, comment 8). The only unresolved thread here is `nsPresContext::GetRootPresContext()` from comment 2, and I've spun off bug 1727437 for it. With that, there's no more auditing to do here, so I think we're good to close this bug.
Bug 1699846 Comment 12 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Note: in the time that's passed since comment 2, we've added two new calls to this API: - One call in DisplayPortUtils.cpp, in `GetRootDisplayportBase`: https://searchfox.org/mozilla-central/rev/9759c03110173c8cf62ba0de21aa9b06b850c794/layout/base/DisplayPortUtils.cpp#1201 - One call call in ViewportUtils.cpp, in `TryInferEnclosingResolution`: https://searchfox.org/mozilla-central/rev/9759c03110173c8cf62ba0de21aa9b06b850c794/layout/base/ViewportUtils.cpp#264 Fortunately I think both of these are fine. Both of these were added in recent commits authored/reviewed by folks working on fission audits (author:hiro, botond; reviewed by: tnikkel/hiro), in patches that were specifically about OOP child frames. So, I think it's safe to assume those callsites have already been vetted as being fine in a fission world. (Also, they're in assertions -- i.e. not in user-affecting logic). Beyond that, the above comments have covered all of the existing callsites (comment 2, comment 3, comment 5, comment 6, comment 8). The only unresolved thread here is `nsPresContext::GetRootPresContext()` from comment 2, and I've spun off bug 1727437 for it. With that, there's no more auditing to do here, so I think we're good to close this bug.