Bug 1702757 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

IIRC the presence of the "brand box" on those pages is controlled by their permissions, in particular only pages running with chrome privilege have the brand box.
Tihs is likely not a regression in Proton, because those same pages don't show the brand text in Photon or any previous themes.
https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp#110 and if I understood correctly the pages with the badge are the ones without nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT
Based on that, we set a "chromeui" attribute here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/base/content/browser-siteIdentity.js#777-779

If we want all the pages to show it, we should probably not rely anymore on the chrome privilege. As I said in the past there have probably been discussion about showing branded pages for everything or just for chrome privileged pages.

Johann, do you remember the reasons for which we decided to show the brand badge only on _isSecureInternalUI, or reasons for which we should not extend that to every about page? I think WebExtensions cannot register new about: pages.
IIRC the presence of the "brand box" on those pages is controlled by their permissions, in particular only pages running with chrome privilege have the brand box.
Tihs is likely not a regression in Proton, because those same pages don't show the brand text in Photon or any previous themes.
https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp#110 and if I understood correctly the pages with the badge are the ones without nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT
Based on that, we set a "chromeui" attribute here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/base/content/browser-siteIdentity.js#777-779

If we want all the pages to show it, we should probably not rely anymore on the chrome privilege and not use the "chromeui" attribute. As I said in the past there have probably been discussion about showing branded pages for everything or just for chrome privileged pages.

Johann, do you remember the reasons for which we decided to show the brand badge only on _isSecureInternalUI, or reasons for which we should not extend that to every about page? I think WebExtensions cannot register new about: pages.
IIRC the presence of the "brand box" on those pages is controlled by their permissions, in particular only pages running with chrome privilege have the brand box.
Tihs is likely not a regression in Proton, because those same pages don't show the brand text in Photon or any previous themes.
https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp#110 and if I understood correctly the pages with the badge are the ones without nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT
Based on that, we set a "chromeui" attribute here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/base/content/browser-siteIdentity.js#777-779

If we want all the pages to show it, we should probably not rely anymore on the chrome privilege and not use the "chromeui" attribute. In the past there have been discussions about showing branded pages for everything or just for chrome privileged pages.

Johann, do you remember the reasons for which we decided to show the brand badge only on _isSecureInternalUI, or reasons for which we should not extend that to every about page? I think WebExtensions cannot register new about: pages.
IIRC the presence of the "brand box" on those pages is controlled by their permissions, in particular only pages running with chrome privilege have the brand box.
This is likely not a regression in Proton, because those same pages don't show the brand text in Photon or any previous themes.
https://searchfox.org/mozilla-central/source/browser/components/about/AboutRedirector.cpp#110 and if I understood correctly the pages with the badge are the ones without nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT
Based on that, we set a "chromeui" attribute here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/browser/base/content/browser-siteIdentity.js#777-779

If we want all the pages to show it, we should probably not rely anymore on the chrome privilege and not use the "chromeui" attribute. In the past there have been discussions about showing branded pages for everything or just for chrome privileged pages.

Johann, do you remember the reasons for which we decided to show the brand badge only on _isSecureInternalUI, or reasons for which we should not extend that to every about page? I think WebExtensions cannot register new about: pages.

Back to Bug 1702757 Comment 1