I added the patches for the add-on sdk. Kept clear for now. Completly unfamiliar with this stuff and not sure if it has side effects. The other parts now drop the version checks. Would probably be enough to fix the bug but so we can later drop the legacy syntax if we want to. buc: I think the removal from Bug 1414546 is not the right thing to do here. Should be an if with results in an unconditional always "true" which can be removed because we always assume we are in js > 1.7 code and so not allowing identifiers and labels names yield. So always returning false. Hopefully I interpreted the SpiderMonkey code right. Tested the dark dark-bg-light-text add-on with this version. Patch is now in the unofficial version to and should appear in Bills next 2.53.8b1 pre.
Bug 1702903 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I added the patches for the add-on sdk. Kept clear for now. Completly unfamiliar with this stuff and not sure if it has side effects. The other parts now drop the version checks. Would probably be enough to fix the bug but so we can later drop the legacy syntax if we want to. buc: I think the removal from Bug 1414546 is not the right thing to do here. Should be an if which results in an unconditional always "true" which can be removed because we always assume we are in js > 1.7 code and so not allowing identifiers and labels named yield. So always returning false. Hopefully I interpreted the SpiderMonkey code right. Tested the dark dark-bg-light-text add-on with this version. Patch is now in the unofficial version to and should appear in Bills next 2.53.8b1 pre.