Bug 1702903 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This needs a followup. I half expected this but hoped it would not be so. 

The code which broke declared yield itself (probably class or var).

>  switch(fieldIdx){
>  case 0:yield.idTextField=item.items.items[0];break;
>  case 1:yield.typeCombo=item.items.items[0];break;
>  case 2:yield.valueTextField=item.items.items[0];break;


[Approval Request Comment]
Regression caused by (bug #): bug 1702903
User impact if declined: some websites where yield is not used as a generator e.g. field definitionwill not work.
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): Low risk. Alternative is to rip out legacy generators.
String changes made by this patch: --
This needs a followup. I half expected this but hoped it would not be so. 

The code which broke declared yield itself (probably class or var).

>  switch(fieldIdx){
>  case 0:yield.idTextField=item.items.items[0];break;
>  case 1:yield.typeCombo=item.items.items[0];break;
>  case 2:yield.valueTextField=item.items.items[0];break;


[Approval Request Comment]
Regression caused by (bug #): bug 1702903
User impact if declined: some websites where yield is not used as a generator e.g. field definition will not work.
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): Low risk. Alternative is to rip out legacy generators.
String changes made by this patch: --
This needs a followup. I half expected this but hoped it would not be so. 

The code which broke declared yield itself (probably class or var).

>  switch(fieldIdx){
>  case 0:yield.idTextField=item.items.items[0];break;
>  case 1:yield.typeCombo=item.items.items[0];break;
>  case 2:yield.valueTextField=item.items.items[0];break;

Fix is to allow legacy generators only in the system or add-on compartments.

[Approval Request Comment]
Regression caused by (bug #): bug 1702903
User impact if declined: some websites where yield is not used as a generator e.g. field definition will not work.
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): Low risk. Alternative is to rip out legacy generators.
String changes made by this patch: --

Back to Bug 1702903 Comment 11