Bug 1703590 Comment 20 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Rob Wu [:robwu] from comment #19)
> Marco, your patch introduces the `autocomplete_popup_separator` color (and even mentions it in the commit description), but I don't see any reference to this color in the Firefox codebase (in particular, not even in `theme.json`). Where is/will this color be used? Is there a follow-up bug?

it's an experimental color in the default themes, that just maps to --autocomplete-popup-separator-color in manifest.json, you should be able to find the latter in the codebase.
https://searchfox.org/mozilla-central/search?q=autocomplete_popup_separator&path=&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=autocomplete-popup-separator-color&path=.css
(In reply to Rob Wu [:robwu] from comment #19)
> Marco, your patch introduces the `autocomplete_popup_separator` color (and even mentions it in the commit description), but I don't see any reference to this color in the Firefox codebase (in particular, not even in `theme.json`). Where is/will this color be used? Is there a follow-up bug?

it's an experimental color in the default themes, that just maps to --autocomplete-popup-separator-color in manifest.json, you should be able to find the latter in the codebase.
https://searchfox.org/mozilla-central/search?q=autocomplete_popup_separator&path=&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=autocomplete-popup-separator-color&path=.css
I don't think theme_experiment is directly affecting theme authors, we're not introducing an official new color here.
(In reply to Rob Wu [:robwu] from comment #19)
> Marco, your patch introduces the `autocomplete_popup_separator` color (and even mentions it in the commit description), but I don't see any reference to this color in the Firefox codebase (in particular, not even in `theme.json`). Where is/will this color be used? Is there a follow-up bug?

it's an experimental color in the default themes, that just maps to --autocomplete-popup-separator-color in manifest.json, you should be able to find the latter in the codebase.
https://searchfox.org/mozilla-central/search?q=autocomplete_popup_separator&path=&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=autocomplete-popup-separator-color&path=.css
I don't think theme_experiment is directly affecting theme authors, we're not introducing an official new color here.

Note for how the default color is defined (using color-mix) the new separators may better adapt to themes (using the currentColor as base)

Back to Bug 1703590 Comment 20