Bug 1703889 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Without Proton, disabled pageactions are shown in the menu, but not pinned of course.
With Proton the menu is gone, so normally disabled page actions are not shown, but in windows smaller than 680px they are shown inside the "overflow" meatball menu. That is inconsistent and Luca in https://phabricator.services.mozilla.com/D111271#inline-620165 suggested we should just hide disabled page action extensions in the overflow menu.

That requires to modify some tests (likely something in pageactions-proton/) and add a new test to extensions/test/browser/browser_ext_menus.js to check disabled add-ons are not shown in the menu.

I'm setting [priority:2a] because add-ons team requested this to happen asap.
Without Proton, disabled pageactions are shown in the menu, but not pinned of course.
With Proton the menu is gone, so normally disabled page actions are not shown, but in windows smaller than 680px they are shown inside the "overflow" meatball menu. That is inconsistent and Luca in https://phabricator.services.mozilla.com/D111271#inline-620165 suggested we should just hide disabled page action extensions in the overflow menu for Proton urlbar.

That requires to modify some tests (likely something in pageactions-proton/) and add a new test to extensions/test/browser/browser_ext_menus.js to check disabled add-ons are not shown in the menu.

I'm setting [priority:2a] because add-ons team requested this to happen asap.

Back to Bug 1703889 Comment 0