Bug 1706006 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

So the last bunch of failures have always the same code path but different error messages:

- `NS_ERROR_FILE_NO_DEVICE_SPACE` which is not actionable
- `NS_ERROR_FILE_NAME_TOO_LONG` and `(NS_ERROR_MODULE_WIN32, 0x7B) -> Illegal file name` which both seem to indicate that there are origins that cannot be represented well by a directory name (and/or we fail some conversion on the way to a valid file name). To securely avoid any problems here we probably need to transform the origin name into some hash value to be used for the directory (which is part of QM v4, IIRC).
So the last bunch of failures have always the same code path but different error messages:

- `NS_ERROR_FILE_NO_DEVICE_SPACE` which is not actionable
- `NS_ERROR_FILE_NAME_TOO_LONG` and `(NS_ERROR_MODULE_WIN32, 0x7B) -> Illegal file name` which both seem to indicate that there are origins that cannot be represented well by a directory name (and/or we fail some conversion on the way to a valid file name). To securely avoid any problems here we probably need to transform the origin name into some hash value to be used for the directory name (which is part of QM v4, IIRC).
So the last bunch of failures have always the same code path but different error messages:

- `NS_ERROR_FILE_NO_DEVICE_SPACE` which is not actionable
- `NS_ERROR_FILE_NAME_TOO_LONG` and `(NS_ERROR_MODULE_WIN32, 0x7B) -> Illegal file name` which both seem to indicate that there are origins that cannot be represented well by a directory name (and/or we fail some conversion on the way to a valid file name). To securely avoid any problems here we probably need to transform the origin name into some hash value to be used for the directory name which is part of QM v4, IIRC. I wonder if that part could be done isolated as a small first step.

Back to Bug 1706006 Comment 6