Bug 1706261 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

It does not appear that |thread_| is ever used by the created thread in the current code, so that is probably fine. The commit that fixed this is here:

https://source.chromium.org/chromium/_/webrtc/src.git/+/97c4458c8fd7b6e81a95f3a0c268d9fe6a335311

It covers a bunch more than just this bug, so the cherry-pick might not be trivial. The patch from the openbsd community looks mostly sufficient, although we might want to also take this line:

https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/platform_thread.cc;l=38;drc=221e331b49dfefadbc6fa40b0c68e6f97606d0b3;bpv=1;bpt=0
It does not appear that |thread_| is ever used by the created thread in the current chromium code, so that is probably fine. The commit that fixed this is here:

https://source.chromium.org/chromium/_/webrtc/src.git/+/97c4458c8fd7b6e81a95f3a0c268d9fe6a335311

It covers a bunch more than just this bug, so the cherry-pick might not be trivial. The patch from the openbsd community looks mostly sufficient, although we might want to also take this line:

https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/platform_thread.cc;l=38;drc=221e331b49dfefadbc6fa40b0c68e6f97606d0b3;bpv=1;bpt=0

Back to Bug 1706261 Comment 4