Bug 1710231 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
LGTM

suite/extensions/irc/js/lib/connection-xpcom.js

NIT

> +            return STATE_IS_BROKEN;
>         else
> -            return [STATE_IS_SECURE, STATE_SECURE_LOW];
> +            return STATE_IS_SECURE;

The else can be removed too. Now a simple if/else and The "return STATE_IS_BROKEN;" is unconditional here.
Revision 1 by
on 
LGTM

suite/extensions/irc/js/lib/connection-xpcom.js

NIT

> +            return STATE_IS_BROKEN;
>         else
> -            return [STATE_IS_SECURE, STATE_SECURE_LOW];
> +            return STATE_IS_SECURE;

The else can be removed too. Now a simple if/else and The "return STATE_IS_BROKEN;" is unconditional here.

>        dd("Exception getting certificate for connection: " + ex.message);
>        return STATE_IS_BROKEN;

Should at least the "return STATE_IS_BROKEN;" moved to be after the catch block?

Function has no return value at the end otherwise and looks a little "unclean".

Back to Bug 1710231 Comment 2