Bug 1711508 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(as noted in bug 1709425, we should not land a patch for this before May 20th, and a patch for bug 1711498 will need to land first)

`protonAppMenuEnabled` just mirrors the `browser.proton.enabled` pref.

This getter and all its (non-test) consumers should be removed.

Any code that only runs if the getter returns false should also be removed. This will need to update the following files (at time of writing - check [this searchfox query](https://searchfox.org/mozilla-central/search?q=protonAppMenuEnabled) to ensure more hasn't been added):

	browser/base/content/browser-places.js
	browser/base/content/browser-sync.js
	browser/components/customizableui/CustomizableWidgets.jsm
	browser/components/customizableui/content/panelUI.js
	browser/modules/ZoomUI.jsm
	browser/components/customizableui/PanelMultiView.jsm
	browser/components/customizableui/content/panelUI.js
Revision 1 by
on 
(as noted in bug 1709425, we should not land a patch for this before May 20th, and a patch for bug 1711498 will need to land first)

`protonAppMenuEnabled` just mirrors the `browser.proton.enabled` pref. This getter and all its (non-test) consumers should be removed.

`protonToolbarEnabled` also mirrors this pref, and currently has no non-test consumers - it should be removed, and `gProtonToolbarEnabled` in CustomizableUI.jsm should also be removed.

Any code that only runs if the getters return false should also be removed. This will need to update the following files (at time of writing - check [this searchfox query](https://searchfox.org/mozilla-central/search?q=protonAppMenuEnabled) to ensure more hasn't been added):

   	browser/base/content/browser-places.js
	browser/base/content/browser-sync.js
	browser/components/customizableui/CustomizableWidgets.jsm
        browser/components/customizableui/CustomizableUI.jsm
	browser/components/customizableui/content/panelUI.js
 	browser/modules/ZoomUI.jsm
	browser/components/customizableui/PanelMultiView.jsm
	browser/components/customizableui/content/panelUI.js
Revision 2 by
on 
(as noted in bug 1709425, we should not land a patch for this before May 20th, and a patch for bug 1711498 will need to land first)

`protonAppMenuEnabled` just mirrors the `browser.proton.enabled` pref. This getter and all its (non-test) consumers should be removed.

`protonToolbarEnabled` also mirrors this pref, and currently has no non-test consumers - it should be removed, and `gProtonToolbarEnabled` in CustomizableUI.jsm should also be removed.

Any code that only runs if the getters return false should also be removed. This will need to update the following files (at time of writing - check [this searchfox query](https://searchfox.org/mozilla-central/search?q=protonAppMenuEnabled) to ensure more hasn't been added):

   	browser/base/content/browser-places.js
	browser/base/content/browser-sync.js
	browser/components/customizableui/CustomizableWidgets.jsm
	browser/components/customizableui/CustomizableUI.jsm
	browser/components/customizableui/content/panelUI.js
 	browser/modules/ZoomUI.jsm
	browser/components/customizableui/PanelMultiView.jsm
	browser/components/customizableui/content/panelUI.js

Back to Bug 1711508 Comment 0