Bug 1714212 Comment 45 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Putting all of this together, here's what I think needs to be done to fix this:

1. Move [a11y::Compatibility::GetActCtxResourceId](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/accessible/windows/msaa/Compatibility.cpp#380) and supporting functions into mozglue.
2. Move accessible/ipc/win/IAccessible*.manifest into mozglue.
3. Change mscom::ProcessRuntime to really differentiate between the parent and launcher processes instead of [treating them the same](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/ipc/mscom/ProcessRuntime.h#27).
4. Change mscom::ProcessRuntime so that the decision to [initialise ActivationContext](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/ipc/mscom/ProcessRuntime.cpp#49) isn't based on MOZILLA_INTERNAL_API. Instead, it should only run if in the parent process (ProcessRuntime::GeckoBrowserParent). We also need to make sure that the ACCESSIBILITY define exists in mozglue; I'm not sure if it does or not.

Note that aklotz is tweaking ProcessRuntime's constructors over in bug 1707954. We should think about how these two things cross over.
Revision 1 by
on 
Putting all of this together, here's what I think needs to be done to fix this:

1. Move [a11y::Compatibility::GetActCtxResourceId](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/accessible/windows/msaa/Compatibility.cpp#380) and supporting functions into mozglue.
2. Move accessible/ipc/win/IAccessible*.manifest into mozglue. This will also require us to [move the manifests out of xulrunner.rc](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/toolkit/library/xulrunner.rc#9) and into a new .rc file for mozglue.
3. Change mscom::ProcessRuntime to really differentiate between the parent and launcher processes instead of [treating them the same](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/ipc/mscom/ProcessRuntime.h#27).
4. Change mscom::ProcessRuntime so that the decision to [initialise ActivationContext](https://searchfox.org/mozilla-central/rev/c0f286b1f541c675bbe052b21bdefa80d150ec35/ipc/mscom/ProcessRuntime.cpp#49) isn't based on MOZILLA_INTERNAL_API. Instead, it should only run if in the parent process (ProcessRuntime::GeckoBrowserParent). We also need to make sure that the ACCESSIBILITY define exists in mozglue; I'm not sure if it does or not.

Note that aklotz is tweaking ProcessRuntime's constructors over in bug 1707954. We should think about how these two things cross over.

Back to Bug 1714212 Comment 45