I got 2 questions: (1) If we're going to expose the preference to about:preferences, will it be synced between desktop and mobile? the default behavior for pop-ups is different between desktop and mobile, that * on desktop, if a website requests a pop-up, it opens a new minimal-pop-up window * on mobile, if a website requests a pop-up, it opens a new tab and previously it was defined by the default value of `browser.link.open_newwindow.restriction`, that * on desktop, if a website requests a pop-up, it opens makes the target a new window (and given the minimal style, it becomes minimal pop-up) * on mobile, if a website requests a pop-up, it's handled in the same way as opening a link that opens new tab So, the default value for the new pref should also be different between desktop and mobile, and I'm wondering sync can break the value between them. I'll investigate it next week. (2) whether to provide the preference UI as "checkbox + dropdown" or "dropdown with default option" the possible options for the pref is: * open pop-up * open new window * open new tab the simple implementation is: `Open allowed pop-ups as [pop-ups/windows/tabs ▾]` where "pop-ups == 1" is selected by default on desktop. this can be single preference value with 1/2/3. the another implementation (as suggested above) is: `[ ] Open pop-ups as [windows/tabs ▾]` where it's unchecked by default on desktop. this can be either 2 preference values with true/false for checkbox, and 1/2 for dropdown, or custom code that maps checkbox+dropdown and single preference value with 1/2/3. anyway, the option UI doesn't make sense on mobile, given there's no pop-ups/windows, so we shouldn't worry about the UI on mobile. (still need to make sure the pref value doesn't get synced between desktop/mobile)
Bug 1714939 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I got 2 questions: (1) If we're going to expose the preference to about:preferences, will it be synced between desktop and mobile? the default behavior for pop-ups is different between desktop and mobile, that * on desktop, if a website requests a pop-up, it opens a new minimal-pop-up window * on mobile, if a website requests a pop-up, it opens a new tab and previously it was defined by the default value of `browser.link.open_newwindow.restriction`, that * on desktop, if a website requests a pop-up, it opens makes the target a new window (and given the minimal style, it becomes minimal pop-up) * on mobile, if a website requests a pop-up, it's handled in the same way as opening a link that opens new tab So, the default value for the new pref should also be different between desktop and mobile, and I'm wondering sync can break the value between them. I'll investigate it next week. (2) whether to provide the preference UI as "checkbox + dropdown" or "dropdown with default option" the possible options for the pref is: * open pop-up * open new window * open new tab the simple implementation is: `Open allowed pop-ups as [pop-ups/windows/tabs ▾]` where "pop-ups == 1" is selected by default on desktop. this can be single preference value with 1/2/3. the another implementation (as suggested above) is: `[ ] Open allowed pop-ups as [windows/tabs ▾]` where it's unchecked by default on desktop. this can be either 2 preference values with true/false for checkbox, and 1/2 for dropdown, or custom code that maps checkbox+dropdown and single preference value with 1/2/3. anyway, the option UI doesn't make sense on mobile, given there's no pop-ups/windows, so we shouldn't worry about the UI on mobile. (still need to make sure the pref value doesn't get synced between desktop/mobile)
I got 2 questions: (1) If we're going to expose the preference to about:preferences, will it be synced between desktop and mobile? the default behavior for pop-ups is different between desktop and mobile, that * on desktop, if a website requests a pop-up, it opens a new minimal-pop-up window * on mobile, if a website requests a pop-up, it opens a new tab and previously it was defined by the default value of `browser.link.open_newwindow.restriction`, that * on desktop, if a website requests a pop-up, it opens makes the target a new window (and given the minimal style, it becomes minimal pop-up) * on mobile, if a website requests a pop-up, it's handled in the same way as opening a link that opens new tab So, the default value for the new pref should also be different between desktop and mobile, and I'm wondering sync can break the value between them. I'll investigate it next week. (2) whether to provide the preference UI as "checkbox + dropdown" or "dropdown with default option" the possible options for the pref is: * open pop-up * open new window * open new tab the simple implementation is: `Open allowed pop-ups as [pop-ups/windows/tabs ▾]` where "pop-ups" is selected by default on desktop. this can be single preference value with 1/2/3. the another implementation (as suggested above) is: `[ ] Open allowed pop-ups as [windows/tabs ▾]` where it's unchecked by default on desktop. this can be either 2 preference values with true/false for checkbox, and 1/2 for dropdown, or custom code that maps checkbox+dropdown and single preference value with 1/2/3. anyway, the option UI doesn't make sense on mobile, given there's no pop-ups/windows, so we shouldn't worry about the UI on mobile. (still need to make sure the pref value doesn't get synced between desktop/mobile)