Bug 1716982 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is a good first bug for newcomers to Firefox development.

`waitForEvent` in the browser/components/preferences test directory can be replaced by the `BrowserTestUtils.waitForEvent` utility function.

The code in question is here: https://searchfox.org/mozilla-central/search?q=+waitForEvent&path=preferences&case=false&regexp=false

Once replaced, the function definition in the head.js file can be removed. In addition to removing the function, the [import for Promise](https://searchfox.org/mozilla-central/rev/b172dd415c475e8b2899560e6005b3a953bead2a/browser/components/preferences/tests/head.js#4) should also be able to be removed.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run the tests with the ./mach mochitest command:

./mach mochitest browser/components/preferences

This will run all the tests in the directory, to make sure that the head.js changes don't adversely affect anything else.

Note this bug will be auto-assigned when the first patch is attached.
This is a good first bug for newcomers to Firefox development.

`waitForEvent` in the browser/components/preferences test directory can be replaced by the `BrowserTestUtils.waitForEvent` utility function.

The code in question is here: https://searchfox.org/mozilla-central/search?q=+waitForEvent&path=preferences&case=false&regexp=false

Once replaced, the function definition in the head.js file can be removed. In addition to removing the function, the [import for Promise](https://searchfox.org/mozilla-central/rev/b172dd415c475e8b2899560e6005b3a953bead2a/browser/components/preferences/tests/head.js#4) should also be able to be removed.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run the tests with the `./mach mochitest` command:

```
./mach mochitest browser/components/preferences
```

You should also make sure that ESLint passed:

```
./mach eslint browser/components/preferences
```

This will run all the tests in the directory, to make sure that the head.js changes don't adversely affect anything else.

Note this bug will be auto-assigned when the first patch is attached.
This is a good first bug for newcomers to Firefox development.

`waitForEvent` in the browser/components/preferences test directory can be replaced by the `BrowserTestUtils.waitForEvent` utility function.

The code in question is here: https://searchfox.org/mozilla-central/search?q=+waitForEvent&path=preferences&case=false&regexp=false

Once replaced, the function definition in the head.js file can be removed. In addition to removing the function, the [import for Promise](https://searchfox.org/mozilla-central/rev/b172dd415c475e8b2899560e6005b3a953bead2a/browser/components/preferences/tests/head.js#4) should also be able to be removed.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run the tests with the `./mach mochitest` command:

```
./mach mochitest browser/components/preferences
```
This will run all the tests in the directory, to make sure that the head.js changes don't adversely affect anything else.

You should also make sure that ESLint passed:

```
./mach eslint browser/components/preferences
```

Note this bug will be auto-assigned when the first patch is attached.

Back to Bug 1716982 Comment 0