Bugzilla

In terms of which problems would require strings before the string freeze next tuesday:

(In reply to Henry Wilkes [:henry] from comment #5)
> + The photo is not an `<img>` element, even though it should be. Plus it would need alt text along the lines of "Contact picture" and "Missing/No contact picture" depending on the state.

Needs alt text.

> + The photo button should be a `<button>` or an `<input type="file">`. I think it should also have a visible "Contact Picture" label, above or below it.

If you go for the visible label, then that needs a string.

If you go for the `<button>` you probably need a `title`. Otherwise, if you go for `<input type="file">` you need a label or a title, depending on your design.

> + The photo image should be an `<img>` with alt text.

I think this could benefit from showing a binary state: "Contact picture" and "Missing contact picture" or "No contact picture". But this might not be necessary if the `<button>` title or `<input type="file">` label already conveys the information.

> + The email addresses table.
>   + See bug 1762126 comment 40.

Specifically, needs a new fluent entry to replace "vcard-email-choose-primary" *without* the `aria-label` because it is not correct to set both the text content and the aria-label. It should probably just be "Default" or "Default email".

>   + Moreover, there are no visible labels in this section, but I think they would be useful for all users. I think the table headings should be made visible rather than screen-reader-only because it is the easiest way to read it. But I know this would be breaking the given design mock ups. As a compromise we could give each selector or input a `title` corresponding to the heading.

Depending on what aleca thinks above, you will need to give these elements a `title` string.

> + The "Websites" and "Phone Numbers" similarly have multiple entries, but are structured differently to the "Email Addresses" section. They should be consistent and use a table as well. The above points would apply to them as well.

Same as above.

@darktrojan Can you start on this since nicolai is away today and friday?

In terms of which problems would require strings before the string freeze next ~~tuesday~~ monday:

(In reply to Henry Wilkes [:henry] from comment #5)
> + The photo is not an `<img>` element, even though it should be. Plus it would need alt text along the lines of "Contact picture" and "Missing/No contact picture" depending on the state.

Needs alt text.

> + The photo button should be a `<button>` or an `<input type="file">`. I think it should also have a visible "Contact Picture" label, above or below it.

If you go for the visible label, then that needs a string.

If you go for the `<button>` you probably need a `title`. Otherwise, if you go for `<input type="file">` you need a label or a title, depending on your design.

> + The photo image should be an `<img>` with alt text.

I think this could benefit from showing a binary state: "Contact picture" and "Missing contact picture" or "No contact picture". But this might not be necessary if the `<button>` title or `<input type="file">` label already conveys the information.

> + The email addresses table.
>   + See bug 1762126 comment 40.

Specifically, needs a new fluent entry to replace "vcard-email-choose-primary" *without* the `aria-label` because it is not correct to set both the text content and the aria-label. It should probably just be "Default" or "Default email".

>   + Moreover, there are no visible labels in this section, but I think they would be useful for all users. I think the table headings should be made visible rather than screen-reader-only because it is the easiest way to read it. But I know this would be breaking the given design mock ups. As a compromise we could give each selector or input a `title` corresponding to the heading.

Depending on what aleca thinks above, you will need to give these elements a `title` string.

> + The "Websites" and "Phone Numbers" similarly have multiple entries, but are structured differently to the "Email Addresses" section. They should be consistent and use a table as well. The above points would apply to them as well.

Same as above.

@darktrojan Can you start on this since nicolai is away today and friday?