After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Having a global state for accepting insecure TLS certificates, and proxy state * Rename `currentSession` to just `session` Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
Bug 1720707 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Having a global state for accepting insecure TLS certificates, and proxy state * Rename `currentSession` to just `session` * Fix `webSocketUrl` generation to return `/session` if `session` is null * Full capability matching for direct BiDi connections Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Having a global state for accepting insecure TLS certificates, and proxy state * Rename `currentSession` to just `session` * Fix `webSocketUrl` generation to return `/session` if `session` is null * Full capability matching for direct BiDi connections * Adding tests for HTTP clients that have to run a WebSocket upgrade path (see this [Phabricator revision](https://phabricator.services.mozilla.com/D120575#3920818) for details) Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Having a global state for accepting insecure TLS certificates, and proxy state * Rename `currentSession` to just `session` * Fix `webSocketUrl` generation to return `/session` if `session` is null * Full capability matching for `session.new` command (bug 1731730) * Adding tests for HTTP clients that have to run a WebSocket upgrade path (see this [Phabricator revision](https://phabricator.services.mozilla.com/D120575#3920818) for details) Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Rename `currentSession` to just `session` * Fix `webSocketUrl` generation to return `/session` if `session` is null * Full capability matching for `session.new` command (bug 1731730) * Having a global state for accepting insecure TLS certificates, and proxy state (bug 1731743) * Adding tests for HTTP clients that have to run a WebSocket upgrade path (see this [Phabricator revision](https://phabricator.services.mozilla.com/D120575#3920818) for details) Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Having a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Having one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Rename `currentSession` to just `session` * Fix `webSocketUrl` generation to return `/session` if `session` is null * Full capability matching for `session.new` command (bug 1731730) * Having a global state for accepting insecure TLS certificates, and proxy state (bug 1731743) * Adding tests for HTTP clients that have to run a WebSocket upgrade path (see this [Phabricator revision](https://phabricator.services.mozilla.com/D120575#3920818) for details) Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) (bug 1696425) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Rename `currentSession` to just `session` * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Restricting to a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Allowing one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Fix `webSocketUrl` generation to return `/session` if `session` is null * Adding tests for HTTP clients that have to run a WebSocket upgrade path (see this [Phabricator revision](https://phabricator.services.mozilla.com/D120575#3920818) for details) Maybe also do the following: * Have the `webdriver-active` flag only set to `true` when there is at least an active session (might be complicated due to performance issues with JSM components - right now it's a const) (bug 1696425) Overall this can cause quite a bit of work and I would suggest to split out individual parts to separate bugs and keep this one as the meta bug.
After a first glance over the refactoring the following seems to be important (maybe more to add): * Rename `currentSession` to just `session` * Having a base WebDriver session class with properties that can be shared between HTTP and BiDi, and a new Set with the name `flags` * Restricting to a single HTTP session which extends the WebDriver session for HTTP specific features (like current browsing context, timeouts, page load strategy, and others) * Allowing one or more BiDi sessions whereby each extends the WebDriver session with BiDi specific features * Do not parse `webSocketUrl` capability for direct BiDi connections * Fix `webSocketUrl` generation to return `/session` if `session` is null