Bug 1722098 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Some background on the issues on macos.

Before Bug 1722098 landed, `.mozbuild/fzf` contained a git repository, and the binary was built in `.mozbuild/fzf/bin`. After Bug 1722098, we only expect the binary, and we expect it directly under `.mozbuild/fzf`.

When you try to use fuzzy for the first time after moving to a changeset which has the changes from this bug (and from Bug 1756813), it will try to look for the binary in `.mozbuild/fzf`, it won't find it (since it's most likely under /bin) and will prompt you to download a new `fzf`. If you accept, `.mozbuild/fzf` will now only contain a `fzf` binary.

And now if you go back to an older revision (old mozilla central, or beta, esr etc...) and try to use fuzzy, it will fail because it can't find the binary under `.mozbuild/fzf/bin`. It will fail with:
```
fatal: not a git repository (or any of the parent directories): .git
Update fzf failed.
```

My suggestion to workaround this was to fully delete the fzf folder in such a case so that the local git repo would be recreated. But it's annoying because as you jump around between old changesets and new changesets you have to do this repeatedly. 

A better solution seems to be to make a copy (or alias?) of the binary `.mozbuild/fzf/fzf` in  `.mozbuild/fzf/bin/fzf`. This way both it should work with all versions.
Some background on the issues on macos.

Before Bug 1722098 landed, `.mozbuild/fzf` contained a git repository, and the binary was built in `.mozbuild/fzf/bin`. After Bug 1722098, we only expect the binary, and we expect it directly under `.mozbuild/fzf`.

When you try to use fuzzy for the first time after moving to a changeset which has the changes from this bug (and from Bug 1756813), it will try to look for the binary in `.mozbuild/fzf`, it won't find it (since it's most likely under /bin) and will prompt you to download a new `fzf`. If you accept, `.mozbuild/fzf` will now only contain a `fzf` binary.

And now if you go back to an older revision (old mozilla central, or beta, esr etc...) and try to use fuzzy, it will fail because it can't find the binary under `.mozbuild/fzf/bin`. It will fail with:
```
fatal: not a git repository (or any of the parent directories): .git
Update fzf failed.
```

My suggestion to workaround this was to fully delete the fzf folder in such a case so that the local git repo would be recreated. But it's annoying because as you jump around between old changesets and new changesets you have to do this repeatedly. 

A better solution seems to be to make a copy (or alias?) of the binary `.mozbuild/fzf/fzf` in  `.mozbuild/fzf/bin/fzf`. This way it should work with all versions.

Back to Bug 1722098 Comment 22